Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Add Card" tab with sub-tab "Edit Cards" #12625

Closed
ryanml opened this issue Nov 11, 2020 · 1 comment · Fixed by brave/brave-core#7114
Closed

Replace "Add Card" tab with sub-tab "Edit Cards" #12625

ryanml opened this issue Nov 11, 2020 · 1 comment · Fixed by brave/brave-core#7114

Comments

@ryanml
Copy link
Contributor

ryanml commented Nov 11, 2020

This is a sub issue under: #9616
Specification: https://docs.google.com/document/d/14lWBt0QmHDfA2G7h0hUPxZ8mVUd008IZPQJJfRryC9U/edit#

(Note, this does not implement the full specification with notifications, only the "Edit Card" addition.

Test Plan

  1. Open up the NTP from a fresh profile
  2. Confirm that "Edit Cards" appears under the widget stack
  3. Confirm that clicking "Edit Cards" brings up the NTP settings focused on the Cards section
  4. Confirm that when all of the widgets are hidden, "Edit Cards" disappears
  5. Confirm that once a widget is added back from zero, "Edit Cards" re-appears
@srirambv
Copy link
Contributor

srirambv commented Jan 5, 2021

Verification passed on

Brave 1.19.72 Chromium: 87.0.4280.101 (Official Build) beta (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Windows 10 OS Version 2009 (Build 19042.685)
  • Verified test plan from issue description
    win-editcards

Verification passed on

Brave 1.19.72 Chromium: 87.0.4280.101 (Official Build) beta (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Linux
  • Verified test plan from issue description
    linux-editcards

Verification passed on

Brave 1.19.72 Chromium: 87.0.4280.101 (Official Build) beta (x86_64)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS macOS Version 10.15.7 (Build 19H2)
  • Verified test plan from issue description
    macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment