Click on the Open in Tor link from Guest window doesn't connect to TOR network

[GeetaSarvadnya]

Description

Click on the Open in Tor link from Guest window doesn't connect to TOR network

Steps to Reproduce

1. Clean profile 1.18.x or 1.17.x
2. Open a normal tab and enter brave.com
3. Click on the Open in Tor link
4. https://brave5t5rjjg3s6k.onion/ opens up in a TOR window 1 and TOR n/w is connected
5. Switch to normal tab, select Guest window from the side bar menu
6. Open brave.com in the Guest window
7. Click on Open in Tor link in the Guest window
8. TOR window 2 is opened and https://brave5t5rjjg3s6k.onion/ is not connected to TOR n/w
9. Open check.torproject.org in TOR window 2
10. TOR is not connected in window 2 but works fine in TOR window 1

Actual result:

Click on the Open in Tor link from Guest window doesn't connect to TOR network

Expected result:

Click on the Open in Tor link from Guest window should connect to TOR network

Reproduces how often:

Always

Brave version (brave://version info)

Brave	1.18.25 Chromium: 87.0.4280.40 (Official Build) nightly (64-bit)
Revision	349b9adbfb2784db684617c7731a57d1e61b3be0-refs/branch-heads/4280@{#863}
OS	Windows 10 OS Version 1903 (Build 18362.1139)

Version/Channel Information:

• Can you reproduce this issue with the current release? NA
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @anthonypkeane @rebron

Please refer thread for more info - https://bravesoftware.slack.com/archives/C7VLGSR55/p1604322378383500

[GeetaSarvadnya]

Verification passed on

Brave | 1.19.64 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)

• Verified the test plan from Make Tor profile an OTR profile associated with the original profile brave-core#7069

Multiple TOR profiles

• Verified the STR from TOR not working with Multiple Profiles Active #12650, ensured that TOR is working in both profile1 and profile 2

profile 1:

profile 2:

• Verified the STR from Click on the Open in Tor link from Guest window doesn't connect to TOR network #12470, ensured that TOR is working fine when a site is opened via Normal window or a Guest window

profile 1:

profile 2:

Tor profile migration

• Installed 1.17.50 dev build and opened TOR window from both default and new profile and quit the browser, upgraded the profile to new brave 1.19.x and ensured that the https://check.torproject.org/ is opened and which is connected to TOR n/w in TOR windows in both profiles ( default and profile 1)

default:

profile 1:

• Verified that the Tor profile is removed from the browser profile folder below
  

Tor Window act like Private Window with Tor connectivity

• Ensured bookmarks Add/Remove/Modified in a TOR window synced with regular profile
• Ensured shield setting inherited from regular profile when Tor window opened, changes made in TOR window will not reflect in regular profile
• Ensured preference like "Show home button" is synced with regular profile

Non component extensions blocked

• Install an extension and turn on Allow in private in brave://extensions/ and opened a Tor window and ensured extension is not accessible in TOR window but shield(component extension) are still working
• Opened 1 Private window and ensured that the installed extension is accessible

Different circuit for different tor profiles

• Opened two profiles default and profile 1, and navigated to https://check.torproject.org/ in TOR windows in both profiles and ensured that different IP address is listed in both profiles

default:

profile 1:

• Clicked on "New Tor connections for this site" on both Tor windows and ensured that different IP address is listed in both profiles

Tor process cleanup

• Verified that Tor Launcher process is listed in the task manager when one/multiple TOR window is opened
  

• Verified that the Tor Launcher process isn't listed in the task manager when TOR window isn't opened
  

---

Verification passed on

Brave	1.19.66 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision	9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS	Ubuntu 18.04 LTS

Verified test plan from the description and brave/brave-core#7069.

Rest of testing done in #12429 (comment)

---

Verified passed with

Brave | 1.19.78 Chromium: 87.0.4280.101 (Official Build) dev (x86_64)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | macOS Version 10.15.7 (Build 19H15)

Verified STR from #12470 (comment)
Confirmed both Tor windows connected to Tor network and opened .onion links successfully.