Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torrents are fully downloaded to memory, potential OOM #1228

Closed
btlechowski opened this issue Sep 21, 2018 · 3 comments
Closed

Torrents are fully downloaded to memory, potential OOM #1228

btlechowski opened this issue Sep 21, 2018 · 3 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Go to https://webtorrent.io/free-torrents
  2. Click on Tears of Steel magnet link
  3. Start downloading the torrent and observe brave memory usage

Actual result:

Torrent is fully downloaded to memory. Even when torrent is finished downloading, memory is not released. It is released only when the torrent tab is closed and the media associated with it is closed.

Tears of Steel has 571 MB.
image

Expected result:

Torrent content is periodically written to disk.

Reproduces how often:

always

Brave version (chrome://version info)

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

cc @yrliou @bridiver

Related issues: #289 #855

@btlechowski btlechowski added bug feature/webtorrent Label for webtorrent related issues labels Sep 21, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Sep 21, 2018
@kjozwiak
Copy link
Member

Great catch @btlechowski 👍

@Brave-Matt
Copy link

@tildelowengrimm
Copy link
Contributor

This looks like a dupe of #1199.

@tildelowengrimm tildelowengrimm added the closed/duplicate Issue has already been reported label Nov 2, 2018
@tildelowengrimm tildelowengrimm modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Nov 2, 2018
@kjozwiak kjozwiak removed bug feature/webtorrent Label for webtorrent related issues labels Nov 2, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

5 participants