Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Brave VPN on Android #12197

Closed
4 tasks done
anthonypkeane opened this issue Oct 19, 2020 · 3 comments
Closed
4 tasks done

Implement Brave VPN on Android #12197

anthonypkeane opened this issue Oct 19, 2020 · 3 comments
Assignees
@deeppandya
Labels
feature/vpn feature-request OS/Android Fixes related to Android browser functionality premium All issues related to Brave Premium priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Required QA/Yes release-notes/include
Milestone
1.39.x - Release

Comments

@anthonypkeane
Copy link

anthonypkeane commented Oct 19, 2020 •
edited by bsclifton
Loading

Description

Please search for the spec "Brave VPN on Android" for details

Related issues / sub-issues
@anthonypkeane anthonypkeane added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes feature-request OS/Android Fixes related to Android browser functionality labels Oct 19, 2020
@deeppandya deeppandya mentioned this issue Feb 9, 2021
Closed
@bsclifton bsclifton mentioned this issue May 12, 2021
Closed
38 tasks
@mattmcalister mattmcalister added feature/vpn premium All issues related to Brave Premium labels May 17, 2021
@brave brave deleted a comment Jul 21, 2021
@bsclifton
Copy link
Member

bsclifton commented Jul 21, 2021 •
edited
Loading

Great progress being made here! Wanted to share a public update 😄

  • We have an implementation (including UI) which works on Android 11 (see here) which adds VPN an in-app-purchase
  • When trying to test this branch out we're running into a weird error. Basically when uploading the arm64 AAB to the Google Play Store (for internal testing) a generic "upload failed" error is happening
  • We're working on resolving this error now
  • Android 10 and earlier implementation is also being worked on; still a work in progress

@bsclifton bsclifton mentioned this issue Apr 25, 2022
Closed
3 tasks
@bsclifton
Copy link
Member

Captured follow up tasks in #22544

The main code for this was merged with brave/brave-core#10692

@deeppandya can you help capture a test plan for VPN? We can either put the test plan here or put on individual issues:

@bsclifton bsclifton added this to the 1.39.x - Beta milestone Apr 25, 2022
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 12, 2022
@Uni-verse
Copy link
Contributor

Verified the following issues mentioned in #12197 (comment) for 1.39.x

known Issues encountered:

  1. VPN setting icon does not match spec - VPN setting icon does not match spec #22848
  2. VPN Support page url needs to be updated on Android - VPN Support page url needs to be updated on Android  #22950
  3. Expiry date should specify if its for trial or for subscription - Expiry date should specify if its for trial or for subscription #23004

@Uni-verse Uni-verse added QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 23, 2022
@kjozwiak kjozwiak mentioned this issue May 25, 2022
Closed
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
Brave Browser 1.39.111 for Android
ab5a62b 
 - Added Brave Firewall + VPN. ([#12197](brave/brave-browser#12197))
 - Added support for blob partitioning. ([#21746](brave/brave-browser#21746))
 - Implemented eth_getEncryptionPublicKey for Brave Wallet. ([#19276](brave/brave-browser#19276))
 - Reduced adblock filter memory usage by optimizing unused regex rules. ([#21970](brave/brave-browser#21970))
 - Removed known Dialog Insight user tracking parameters from URLs. ([#22082](brave/brave-browser#22082))
 - Fixed breakage in webpack build caused by OpenSSL 3.0. ([#22305](brave/brave-browser#22305))
 - Fixed pending bell icon under Brave Wallet not being displayed when new unapproved requests are created. ([#21654](brave/brave-browser#21654))
 - Fixed expand icon under Brave Shields using incorrect color when the Privacy Hub has been enabled. ([#22049](brave/brave-browser#22049))
 - Upgraded Chromium to 102.0.5005.61. ([#22923](brave/brave-browser#22923)) ([Changelog for 102.0.5005.61](https://chromium.googlesource.com/chromium/src/+log/101.0.4951.67..102.0.5005.61?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/vpn feature-request OS/Android Fixes related to Android browser functionality premium All issues related to Brave Premium priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Required QA/Yes release-notes/include
Projects
None yet
Milestone
1.39.x - Release
Development

No branches or pull requests
6 participants
@mattmcalister @stephendonner @bsclifton @deeppandya @anthonypkeane @Uni-verse