Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Open link in New Tor Private Window via context menu opens a tab with new tab #11611

Closed
simonhong opened this issue Sep 6, 2020 · 2 comments · Fixed by brave/brave-core#10440

Comments

@simonhong
Copy link
Member

Description

Try opening a link via context menu in New Tor Private Window.
If there is no existed tor window, new tor window is created and that window has NTP and tab that loads requested link.
According to the #1387 (comment), this is expected behavior.

Steps to Reproduce

  1. Launch Browser and make sure thare is no tor private window
  2. Select Open link in private window with Tor menu via context menu in normal window
  3. Newly created tor window has two tabs - NTP and requested link

Actual result:

New tor window has NTP tab.

Expected result:

New tor window should have one tab that loads requested url

Reproduces how often:

Easily

Brave version (brave://version info)

Since 0.55

Version/Channel Information:

All channels

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@stephendonner
Copy link

Verified PASSED using

Brave 1.32.66 Chromium: 95.0.4638.40 (Official Build) nightly (x86_64)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS macOS Version 11.6 (Build 20G165)

Confirmed that context-clicking on a URL and choosing Open Link in Private Window with Tor resulted in the Tor tab loading the link correctly, with no other (empty) tabs.

Screen Shot 2021-10-12 at 12 20 47 PM

Reproduced the problem in

Brave 1.31.82 Chromium: 95.0.4638.40 (Official Build) beta (x86_64)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS macOS Version 11.6 (Build 20G165)

Screen Shot 2021-10-12 at 12 20 11 PM

where I got an extra, empty tab to the left of the correctly opened link in Tor.

1 similar comment
@stephendonner
Copy link

Verified PASSED using

Brave 1.32.66 Chromium: 95.0.4638.40 (Official Build) nightly (x86_64)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS macOS Version 11.6 (Build 20G165)

Confirmed that context-clicking on a URL and choosing Open Link in Private Window with Tor resulted in the Tor tab loading the link correctly, with no other (empty) tabs.

Screen Shot 2021-10-12 at 12 20 47 PM

Reproduced the problem in

Brave 1.31.82 Chromium: 95.0.4638.40 (Official Build) beta (x86_64)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS macOS Version 11.6 (Build 20G165)

Screen Shot 2021-10-12 at 12 20 11 PM

where I got an extra, empty tab to the left of the correctly opened link in Tor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants