Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] [Security] add rel=noopener to webtorrent link #11487

Closed
diracdeltas opened this issue Aug 27, 2020 · 1 comment · Fixed by brave/brave-core#6523
Closed

[Desktop] [Security] add rel=noopener to webtorrent link #11487

diracdeltas opened this issue Aug 27, 2020 · 1 comment · Fixed by brave/brave-core#6523
Assignees
@diracdeltas
Labels
feature/webtorrent Label for webtorrent related issues OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include security
Milestone
1.15.x - Release #1

Comments

@diracdeltas
Copy link
Member

https://hackerone.com/reports/968328
@diracdeltas diracdeltas added security feature/webtorrent Label for webtorrent related issues OS/Desktop labels Aug 27, 2020
@diracdeltas diracdeltas self-assigned this Aug 27, 2020
@diracdeltas diracdeltas mentioned this issue Aug 27, 2020
Merged
32 tasks
diracdeltas added a commit to diracdeltas/brave-core that referenced this issue Aug 28, 2020
@diracdeltas
Add rel=noopener to WebTorrent target=_blank link
00704d9 
fix brave/brave-browser#11487

rebase
@diracdeltas diracdeltas changed the title [Desktop] webtorrent redirects security issue [Desktop] add rel=noopener to webtorrent link Aug 28, 2020
@diracdeltas diracdeltas changed the title [Desktop] add rel=noopener to webtorrent link [Desktop] [Security] add rel=noopener to webtorrent link Aug 28, 2020
@diracdeltas diracdeltas added this to the 1.15.x - Nightly milestone Aug 28, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Sep 17, 2020 •
edited by GeetaSarvadnya
Loading

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.15.55 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | macOS Version 10.15.6 (Build 19G73)

Reproduced the original issue using 1.14.81 C: 85.R0.4183.102 as per the following:

Original Issue Reproduced Original Issue Reproduced
Screen Shot 2020-09-17 at 3 51 41 PM Screen Shot 2020-09-17 at 3 51 34 PM

Verification passed on

Brave 1.15.55 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Ubuntu 18.04 LTS

Verification passed on


Brave | 1.15.55 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

@kjozwiak kjozwiak mentioned this issue Oct 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diracdeltas diracdeltas

Labels
feature/webtorrent Label for webtorrent related issues OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include security
Projects
None yet
Milestone
1.15.x - Release #1
Development

Successfully merging a pull request may close this issue.

Add rel=noopener to WebTorrent target=_blank links diracdeltas/brave-core
4 participants
@diracdeltas @kjozwiak @btlechowski @GeetaSarvadnya