Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop][CW][Follow up #11103] Spacing between widget cards is not as per spec when Brave together is not available #11441

Closed
srirambv opened this issue Aug 26, 2020 · 4 comments · Fixed by brave/brave-core#6768

Comments

@srirambv
Copy link
Contributor

Description

[Follow up #11103] Spacing between widget cards is not as per spec when Brave together is not available

Steps to Reproduce

  1. Upgrade to 1.13.80 RC build
  2. Open a new tab and open dashboard settings
  3. Go to More cards, there is no spacing between cards aligned in two columns as Brave Together card is missing

Actual result:

image

Expected result:

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.13.80 Chromium: 85.0.4183.83 (Official Build) (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @karenkliu

@karenkliu
Copy link

That's really weird that this is still showing up - I thought @ryanml already fixed this issue with the most recent updates.

@ryanml
Copy link
Contributor

ryanml commented Aug 27, 2020

I specifically did address this one, only thing I can think of: @srirambv, do you see this present on Nightly when the Together banner is showing? I'm wondering if that is what is maybe causing this issue. cc: @karenkliu

@srirambv
Copy link
Contributor Author

@ryanml yes this only happens when Brave Together is not available which will be most of the countries excluding NA. This is how it looks on the following build

Brave 1.15.12 Chromium: 85.0.4183.83 (Official Build) nightly (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Linux
With Brave Together Without Brave Together
Screenshot 2020-08-27 at 5 39 55 a m Screenshot 2020-08-27 at 5 41 16 a m

@LaurenWags
Copy link
Member

LaurenWags commented Oct 29, 2020

Verified passed with

Brave | 1.17.55 Chromium: 86.0.4240.111 (Official Build) dev (x86_64)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | macOS Version 10.14.6 (Build 18G6032)

Verified STR from description

Screen Shot 2020-10-29 at 8 16 31 AM

Logged #12381 for overlapping scroll bars


Verification passed on

Brave | 1.17.55 Chromium: 86.0.4240.111 (Official Build) dev (64-bit)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | Windows 10 OS Version 1903 (Build 18362.1139)


Verification passed on

Brave 1.17.59 Chromium: 86.0.4240.183 (Official Build) dev (64-bit)
Revision 0b568b034b8f7994697cb341eeca5979b84151cc-refs/branch-heads/4240@{#1374}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment