Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] update Safe Browsing text in brave://settings #11345

Closed
rebron opened this issue Aug 20, 2020 · 6 comments · Fixed by brave/brave-core#6699
Closed

[Desktop] update Safe Browsing text in brave://settings #11345

rebron opened this issue Aug 20, 2020 · 6 comments · Fixed by brave/brave-core#6699
Assignees
Labels
feature/global-settings Settings at browser level independent of shields settings needs-text-change This change requires some careful wording. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Aug 20, 2020

Description

Update Safebrowsing text in brave://settings/privacy and brave://settings/safetyCheck for Chromium 86, in the "No protection section".

Steps to Reproduce

  1. Use a build of Brave with cr86
  2. Go to brave://settings/privacy and brave://settings/safetyCheck and notice screens in Actual result.

Actual result:

first screen -
image-2

second screen -
Screen Shot 2020-09-24 at 10 30 00 AM

Expected result:

first screen:
"Standard Protection" text remove:
If a site tries to steal your password, or when you download a harmful file, Brave may also send URLs, including bits of page content, to Safe Browsing.

"No Protection" text should read (basically remove the second sentence):
Does not protect you against dangerous websites, downloads, and extensions.

second screen:
"Safe Browsing" text should read when on (basically remove the second sentence. No change in text if Safe browsing is off):
Standard protection is on.

Reproduces how often:

Easily.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron rebron added needs-text-change This change requires some careful wording. feature/global-settings Settings at browser level independent of shields settings priority/P3 The next thing for us to work on. It'll ride the trains. needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop labels Aug 20, 2020
@rebron rebron removed the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Sep 24, 2020
@rebron rebron removed their assignment Sep 24, 2020
@fmarier
Copy link
Member

fmarier commented Sep 24, 2020

Also, we should remove this bit from Standard Protection:

If a site tries to steal your password, or when you download a harmful file, Brave may also send URLs, including bits of page content, to Safe Browsing.

since we disable that in Brave.

@LaurenWags
Copy link
Member

LaurenWags commented Sep 25, 2020

@rebron @fmarier is the part in the box that says Checks URLs with a list of unsafe sites stored in Brave accurate? Is there a list of unsafe sites stored somewhere?

Screen Shot 2020-09-25 at 9 44 21 AM

@fmarier
Copy link
Member

fmarier commented Sep 25, 2020

@LaurenWags Yes, that part is accurate. The list is stored here:

$ ls ~/.config/BraveSoftware/Brave-Browser-Beta/Safe\ Browsing
ChromeExtMalware.store  UrlBilling.store  UrlMalware.store  UrlUws.store
IpMalware.store         UrlMalBin.store   UrlSoceng.store

@LaurenWags
Copy link
Member

great, thanks for clarifying @fmarier!

@btlechowski
Copy link

Requires build higher than 1.15.69. Marked it as QA/Blocked till we get a new build.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 5, 2020

Verification passed on


Brave | 1.15.70 Chromium: 86.0.4240.68 (Official Build) (64-bit)
-- | --
Revision | ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

  • Verified STR from the description

image

image


Verified passed with

Brave | 1.15.70 Chromium: 86.0.4240.68 (Official Build) (x86_64)
-- | --
Revision | ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified STR from description

Navigate to brave://settings/privacy and click on "Security". You are navigated to brave://settings/security:
Screen Shot 2020-10-05 at 8 07 18 AM

Navigate to brave://settings/safetyCheck and click "Check now" button when Safe Browsing is on:
Screen Shot 2020-10-05 at 8 08 01 AM

Navigate to brave://settings/safetyCheck and click "Check now" button when Safe Browsing is off:
Screen Shot 2020-10-05 at 8 13 20 AM


Verification passed on

Brave 1.15.70 Chromium: 86.0.4240.68 (Official Build) (64-bit)
Revision ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS Ubuntu 18.04 LTS

Verified STR from description

Navigate to brave://settings/privacy and click on "Security". You are navigated to brave://settings/security:
image

Navigate to brave://settings/safetyCheck and click "Check now" button when Safe Browsing is on:
image

Navigate to brave://settings/safetyCheck and click "Check now" button when Safe Browsing is off:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings needs-text-change This change requires some careful wording. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants