Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Mark promotion as over if not in response #11170

Closed
NejcZdovc opened this issue Aug 11, 2020 · 0 comments · Fixed by brave/brave-core#6403
Closed

[Desktop] Mark promotion as over if not in response #11170

NejcZdovc opened this issue Aug 11, 2020 · 0 comments · Fixed by brave/brave-core#6403

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Aug 11, 2020

Right now we store promotions in db and relay on expire_at field to know when they expire. We also need to support use case if promotion is remove from response payload and it's still marked as active in db. In this case we need to mark promotion as over.

We should also remove details button in wallet section so that fetch only returns active promotions now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant