Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 83 to Chromium 84 #10364

Closed
mkarolin opened this issue Jun 18, 2020 · 1 comment · Fixed by #10363 or brave/brave-core#5679
Closed

Upgrade from Chromium 83 to Chromium 84 #10364

mkarolin opened this issue Jun 18, 2020 · 1 comment · Fixed by #10363 or brave/brave-core#5679
Assignees
Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA/Test-Plan-Specified release-notes/exclude

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Jun 18, 2020

Upgrade from Chromium 83.0.x.x to Chromium 83.0.4147.XX

https://chromium.googlesource.com/chromium/src/+log/83.0.4103.106..84.0.4147.56/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Affected areas:

  1. Settings page.
    • Please thoroughly test all our settings modifications, e.g. "clear data on exit", content settings categories (if we still customize those), brave theme, shields preferences, and strings, etc.
  2. All Chromium WebUI's (settings, history, downloads, bookmarks, extensions):
    • Are buttons, toggles, links, checkboxes all using brave colors (red and not blue)?
    • Does the toolbar and the toolbar search work properly?
  3. Importing encrypted data from Brave/Chrome/Chromium on Linux.
  4. Crash reporting (verify that reports arrive to our server).
  5. Settings UI: check that Brave version shows correctly.
  6. Check that Shields settings are preserved on browser exist/restart.
  7. Check ability to download/update extensions.
@kjozwiak
Copy link
Member

kjozwiak commented Jul 9, 2020

Labeling following as QA/No in favour of #10594. We'll also mention that the area's that @mkarolin mentioned via #10364 (comment) get tested in #10594.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
2 participants