Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension popups have a white strip at the top and bottom #1028

Closed
cndouglas opened this issue Sep 7, 2018 · 9 comments · Fixed by brave/brave-core#626
Closed

Extension popups have a white strip at the top and bottom #1028

cndouglas opened this issue Sep 7, 2018 · 9 comments · Fixed by brave/brave-core#626
Assignees
@petemill
Labels
bug feature/extensions feature/user-interface All UI related OS/macOS OS/Windows pr/pending-review QA/Yes
Milestone
0.55.x - Release ...

Comments

@cndouglas
Copy link
Contributor

Description

There is a white strip at the top of popups for extensions (including the Brave shields panel extension).

Steps to Reproduce

  1. Open a new tab and navigate to any website.
  2. Click the Brave shields button.

Actual result:

Also occurs with third-party extensions like Bitwarden:

Expected result:

There should not be a white strip.

Reproduces how often:

Always.

Brave version (about:brave info)

Version 0.55.1 Chromium: 70.0.3528.4 (Official Build) dev (64-bit)

Reproducible on current release:

No.
@petemill petemill added this to the Releasable builds 0.55.x milestone Sep 7, 2018
@srirambv
Copy link
Contributor

srirambv commented Sep 8, 2018

This is not an issue on Linux. Its definitely an issue on Windows.
image

@liunkae the screenshots you posted is it from macOS ?

@cndouglas
Copy link
Contributor Author

@srirambv Yes, macOS 10.13.

@cndouglas
Copy link
Contributor Author

Maybe related:
If you click the ad/trackers blocked label to show the URLs, there is a white strip on the right (scrollbar placeholder?).

@srirambv
Copy link
Contributor

srirambv commented Sep 8, 2018

The extra padding when showing blocked items is tracked here #771

@petemill
Copy link
Member

I think this is a chromium bug that is now fixed. We should check against latest chromium rebase https://bugs.chromium.org/p/chromium/issues/detail?id=849802

@petemill petemill self-assigned this Sep 10, 2018
@petemill
Copy link
Member

This was fixed with a revert in chromium https://chromium.googlesource.com/chromium/src.git/+/ba30493edf9b0417de03cae95f6da4815e4c3ec8%5E%21/#F1 which I confirm I have locally, but issue still persists 🤷‍♂️

Will investigate further

@srirambv srirambv added feature/user-interface All UI related and removed feature/ui labels Sep 18, 2018
@petemill
Copy link
Member

This is actually sort of by-design in Chromium, and like this in the current version.

I believe it's due to not being able to support rounded corners on web content in Windows and macOS. The border radius was reduced as to not make it so apparent, but it's still an eyesore IMO. We should consider removing border radius entirely if the fix is too difficult.

image

@rebron
Copy link
Collaborator

rebron commented Sep 30, 2018

This issue will impact shields style update #1339
yes?

@bbondy bbondy added the QA/Yes label Oct 10, 2018
@srirambv srirambv mentioned this issue Oct 12, 2018
Closed
@srirambv
Copy link
Contributor

+1 from @echosa for Brave rewards via #1554
image

@cndouglas cndouglas changed the title Extension popups have a white strip at the top Extension popups have a white strip at the top and bottom Oct 12, 2018
petemill added a commit to brave/brave-core that referenced this issue Oct 13, 2018
@petemill
Remove border radius from brave extension popup windows
fa108b8 
Fix brave/brave-browser#1028

This is unfortunate in two ways:
1. It's an ugly patch. ExtensionPopup is both instantiated on its own (macOS) and as a parent class of ExtensionPopupAura. I believe attempting to create a BraveExtensionPopup that both replaces ExtensionPopup and the parent class of ExtensionPopupAura would lead to a larger web of patches, but happy to be shown otherwise.
2. It fixes the issue of the white strips by removing the border radius entirely. The much preferred option is to support the native window radius clipping the webview, but chromium does not yet support this.
@petemill petemill mentioned this issue Oct 13, 2018
Merged
18 tasks
@simonhong simonhong mentioned this issue Oct 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
bug feature/extensions feature/user-interface All UI related OS/macOS OS/Windows pr/pending-review QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Remove border radius from brave extension popup windows brave/brave-core
5 participants
@petemill @bbondy @rebron @srirambv @cndouglas