Auto Contribute does not work if there is more than 1 verified publisher in AC list #10058

LaurenWags · 2020-06-02T15:46:21Z

Description

If you have more than 1 verified publisher in AC list, auto contribute does not occur properly. Experienced when doing AC w/ KYC'd uphold wallet, but should check user funded (anon) and VG funded wallets also

Steps to Reproduce

Clean profile w/ flags like /Applications/Brave\ Browser\ Dev.app/Contents/MacOS/Brave\ Browser\ Dev --enable-logging=stderr --vmodule=*rewards*=6 --log-level=2 --rewards=staging=true,reconcile-interval=3 --brave-ads-staging
Enable Rewards
Connect KYC'd uphold account
Add at least 2 verified publishers to AC list (I used ddg and laurenwags.github.io)
Wait for AC to occur.

** When retesting, check w/ VG BAT and user funded (restored anon wallet) for step 3)

Actual result:

Balance decreases by monthly budget but AC does not get listed in UI/monthly summary. Logs show it is retrying.

Expected result:

AC should work

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.10.80 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

Can you reproduce this issue with the current release? no
Can you reproduce this issue with the beta channel?
Can you reproduce this issue with the dev channel? yes
Can you reproduce this issue with the nightly channel?

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @rebron @brave/legacy_qa

The text was updated successfully, but these errors were encountered:

GeetaSarvadnya · 2020-06-02T17:26:56Z

The issue is reproduced on


Brave | 1.10.80 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

GeetaSarvadnya · 2020-06-02T18:08:35Z

@NejcZdovc @LaurenWags Here are my observations on the issue.

Launched brave using staging flag and reconcile interval of 4 mins
Claimed UGP grants of 20 BAT
Added DDG and laurenwags.github.io pubs to AC table
waited for 4 mins
AC did not happen
Wallet balance reduced to 14.5 BAT at 6th min
Wallet balance reduced to 10 BAT at 8th min
Received AC notification at 9th min and AC recorded in summary and monthly statement

LaurenWags · 2020-06-03T11:32:15Z

@GeetaSarvadnya ok so looks like if you fund your wallet via VG (like UGP grant) then this works. we should double check that's still the case after this is fixed. We will also want to confirm if user funded anon cards work as well for AC.

Resolves brave/brave-browser#10058

GeetaSarvadnya · 2020-06-10T11:26:59Z

Verification passed on


Brave | 1.10.87 Chromium: 83.0.4103.61 (Official Build) (64-bit)
-- | --
Revision | 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Verified the test plan from Fixes ac for multiple publishers brave-core#5728 (comment)

Scenario 1:

Confirmed AC is listed in brave://rewards and on Monthly Summary:
Confirmed AC listed in database:

Scenario 2 (wallet funded via VG like UGP grant):

Confirmed AC is listed in brave://rewards and on Monthly Summary:
Confirmed AC listed in the database:

Scenario 3 (wallet funded via restored anon wallet):

Confirmed AC is listed in brave://rewards and on Monthly Summary:
Confirmed AC listed in the database:

Scenario 4 (Wallet funded via Ad grants and connect the wallet to KYC'd uphold account)

Enable rewards
Restore Ad grants and claim ad grants
Connect to KYC'd uphold account
Add multiple verified pubs to AC table
Set recurring tips
Trigger AC
Confirmed AC is listed in brave://rewards and on Monthly Summary:
Confirmed AC listed in the database:

Scenario 5 ( Wallet funded via ad grants)

Enable rewards
Restore Ad grants
Claim ad grants
Add multiple verified pubs to AC table
Set multiple recurring tips
Send a one-time tip to multiple pubs
Confirmed AC is listed in brave://rewards and on Monthly Summary:

Confirmed AC listed in the database:

Scenario 6 (Wallet funded via restore wallet and connect wallet to non verified uphold account)

Confirmed AC is listed in brave://rewards and on Monthly Summary:
Confirmed AC listed in the database:

Scenario 7 (Wallet is funded via UGP grants and Ad grants)

Confirmed AC is listed in brave://rewards and on Monthly Summary:
Confirmed AC listed in the database:

Scenario 8 ( wallet is funded via UGP+KYC'd uphold wallet)

Confirmed AC is listed in brave://rewards and on Monthly Summary:
Confirmed AC listed in the database:

Verified passed with below version and staging env:

Brave | 1.10.88 Chromium: 83.0.4103.97 (Official Build) (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | macOS Version 10.14.6 (Build 18G3020)

Scenario 1 (wallet funded via KYC'd Uphold wallet)

Verified STR from description
Confirmed AC was completed and listed in UI/DB

Scenario 2 (wallet funded via VG like UGP grant):

Clean profile w/ flags
Enable Rewards
Claim UGP.
Add at least 2 verified publishers to AC list
Wait for AC to occur.
Confirmed AC was completed and listed in UI/DB

Scenario 3 (wallet funded via restored anon wallet):

Clean profile w/ flags
Enable Rewards
Restore wallet w/ previously funded user BAT
Add at least 2 verified publishers to AC list
Wait for AC to occur.
Confirmed AC was completed and listed in UI/DB

Verification passed on:

Brave	1.10.90 Chromium: 83.0.4103.97 (Official Build) (64-bit)
Revision	326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{# 657}
OS	Linux

Scenario 1 (wallet funded via VG like UGP grant):

Clean profile on 1.10.90
Enable Rewards on staging
Claim UGP.
Add at least 2 verified publishers to AC list
Trigger AC
Confirmed AC was completed and listed in UI
Confirmed AC was completed and listed in DB

Scenario 2 (wallet funded via restored anon wallet):

Clean profile on 1.10.90
Enable Rewards on staging
Restore wallet w/ previously funded user BAT
Add at least 2 verified publishers to AC list
Trigger AC
Confirmed AC was completed and listed in UI
Confirmed AC was completed and listed in DB

Scenario 3 (wallet funded via KYC'd Uphold wallet)

Verified STR from description
Confirmed AC was completed and listed in UI/DB
Encountered [Desktop] AC SKU doesn't continue retrying if you restart the browser #10243 that @LaurenWags logged

LaurenWags added release/blocking feature/rewards QA/Yes regression labels Jun 2, 2020

LaurenWags added this to the 1.10.x - Beta milestone Jun 2, 2020

NejcZdovc self-assigned this Jun 2, 2020

This was referenced Jun 2, 2020

AC isn't going through for the connected publisher from KYC'd uphold account #9962

Closed

AC with virtual grants flow with uphold funds #7595

Closed

LaurenWags mentioned this issue Jun 3, 2020

monthly contributions contributing again after browser restart when AC is disabled #10006

Closed

NejcZdovc mentioned this issue Jun 3, 2020

Fixes ac for multiple publishers brave/brave-core#5728

Merged

32 tasks

NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 3, 2020

Fixes ac for multiple publishers

44f7fa9

Resolves brave/brave-browser#10058

NejcZdovc closed this as completed in brave/brave-core#5728 Jun 3, 2020

NejcZdovc mentioned this issue Jun 4, 2020

Fixes ac for multiple publishers (uplift to 1.10.x) brave/brave-core#5736

Merged

4 tasks

NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 4, 2020

Fixes ac for multiple publishers

2bcd19b

Resolves brave/brave-browser#10058

This was referenced Jun 4, 2020

Manual test run on OS X for 1.10.x - Beta #10089

Closed

Manual test run on Windows x64 for 1.10.x - Beta #10090

Closed

Manual test run on Linux for 1.10.x - Beta #10091

Closed

GeetaSarvadnya added the QA Pass-Win64 label Jun 10, 2020

NejcZdovc added the release-notes/exclude label Jun 10, 2020

LaurenWags added the QA Pass-macOS label Jun 11, 2020

srirambv added the QA Pass-Linux label Jun 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto Contribute does not work if there is more than 1 verified publisher in AC list #10058

Auto Contribute does not work if there is more than 1 verified publisher in AC list #10058

LaurenWags commented Jun 2, 2020

GeetaSarvadnya commented Jun 2, 2020

GeetaSarvadnya commented Jun 2, 2020 •

edited

Loading

LaurenWags commented Jun 3, 2020

GeetaSarvadnya commented Jun 10, 2020 •

edited by srirambv

Loading

Auto Contribute does not work if there is more than 1 verified publisher in AC list #10058

Auto Contribute does not work if there is more than 1 verified publisher in AC list #10058

Comments

LaurenWags commented Jun 2, 2020

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

GeetaSarvadnya commented Jun 2, 2020

GeetaSarvadnya commented Jun 2, 2020 • edited Loading

LaurenWags commented Jun 3, 2020

GeetaSarvadnya commented Jun 10, 2020 • edited by srirambv Loading

GeetaSarvadnya commented Jun 2, 2020 •

edited

Loading

GeetaSarvadnya commented Jun 10, 2020 •

edited by srirambv

Loading