Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ads.brave.com does not load on iOS (blank page) #564

Closed
Miyayes opened this issue Mar 31, 2021 · 2 comments · Fixed by #584
Closed

ads.brave.com does not load on iOS (blank page) #564

Miyayes opened this issue Mar 31, 2021 · 2 comments · Fixed by #584
Assignees
@dlipeles @iambrianfung
Labels
Bug Something isn't working P1

Comments

@Miyayes
Copy link

Miyayes commented Mar 31, 2021 •
edited
Loading

Description

On desktop, when visiting ads.brave.com, it successfully redirects to brave.com/brave-ads. However, on mobile iOS, it will just show a blank page and not complete the redirection.
@Miyayes Miyayes changed the title ads.brave.com does not load on mobile (blank page) ads.brave.com does not load on iOS (blank page) Mar 31, 2021
@saberistic saberistic added Bug Something isn't working P1 labels Mar 31, 2021
@saberistic
Copy link
Contributor

observing following in safari
image

https://stackoverflow.com/questions/51568821/works-in-chrome-but-breaks-in-safari-invalid-regular-expression-invalid-group/51568859

@iambrianfung
Copy link
Collaborator

Issue arises from normalize-url version.
sindresorhus/normalize-url#105

should point to version 4.
https://github.com/sindresorhus/normalize-url#install

@tackley tackley mentioned this issue Jul 21, 2021
Closed
tackley added a commit that referenced this issue Sep 27, 2021
@tackley
Downgrade normalize-url
29f043c 
So that the website successfully loads on safari.

Re #564
@tackley tackley mentioned this issue Sep 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlipeles dlipeles

@iambrianfung iambrianfung

Labels
Bug Something isn't working P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Production Release 2021-09-27 brave/ads-ui
4 participants
@dlipeles @saberistic @Miyayes @iambrianfung