Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Cargo.lock file #75

Closed
oneingan opened this issue Sep 5, 2024 · 1 comment · Fixed by #77
Closed

Missing Cargo.lock file #75

oneingan opened this issue Sep 5, 2024 · 1 comment · Fixed by #77

Comments

@oneingan
Copy link

oneingan commented Sep 5, 2024

Hi! I noticed that the repository doesn't include a Cargo.lock file. While I understand this might be intentional, including Cargo.lock can help ensure consistent builds across different environments and make dependency management a bit easier.

Would you consider adding it? It would be super helpful, especially for reproducibility in production setups.

brandur added a commit that referenced this issue Sep 5, 2024
Include `Cargo.lock` as requested in #75.

I think I originally omitted it so that no one was stuck to specific
dependency versions that really didn't make any difference whatsoever,
but I guess that's not that big of a problem, and the lock file has some
nominal benefit for reproducibility/security.
brandur added a commit that referenced this issue Sep 5, 2024
Include `Cargo.lock` as requested in #75.

I think I originally omitted it so that no one was stuck to specific
dependency versions that really didn't make any difference whatsoever,
but I guess that's not that big of a problem, and the lock file has some
nominal benefit for reproducibility/security.

Fixes #75.
@brandur
Copy link
Owner

brandur commented Sep 5, 2024

Can't hurt I guess. Opened #77.

brandur added a commit that referenced this issue Sep 5, 2024
Include `Cargo.lock` as requested in #75.

I think I originally omitted it so that no one was stuck to specific
dependency versions that really didn't make any difference whatsoever,
but I guess that's not that big of a problem, and the lock file has some
nominal benefit for reproducibility/security.

Fixes #75.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants