Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fscomponents): Add formik, yup to fscomponents and LoginForm #995

Merged
merged 2 commits into from
Jan 24, 2020

Conversation

varzaman
Copy link

@varzaman varzaman commented Jan 17, 2020

https://jira.brandingbrand.com/browse/FLAGSHIP-79

Notes:

  • Implemented Formik and Yup for LoginForm
  • New TextInput wrapper made (TextField) that has a label and error messaging part of it
  • Storybook made for LoginForm to show what can be changed
  • Does not have ability to change location of the labels like in the current LoginForm

@varzaman varzaman requested a review from bweissbart January 17, 2020 19:17
@Cauldrath Cauldrath self-assigned this Jan 24, 2020
Copy link

@Cauldrath Cauldrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@Cauldrath Cauldrath merged commit 638b466 into brandingbrand:develop Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants