Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fscomponents): FLAGSHIP-58 Updating To Function Component #992

Merged
merged 1 commit into from
Jan 23, 2020
Merged

refactor(fscomponents): FLAGSHIP-58 Updating To Function Component #992

merged 1 commit into from
Jan 23, 2020

Conversation

willybeans
Copy link

@willybeans willybeans commented Jan 17, 2020 •
edited
Loading

Ticket:

Description:

  • Update ProductMetadata to function component

Test:

  • run fs test builds

Screen Shot 2020-01-17 at 11 55 53 AM

I couldnt get the test project to compile so this was only tested with storybook

@willybeans willybeans marked this pull request as ready for review January 17, 2020 17:01
@Cauldrath Cauldrath self-assigned this Jan 22, 2020
Cauldrath
Cauldrath approved these changes Jan 23, 2020
View reviewed changes
Copy link

@Cauldrath Cauldrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@Cauldrath Cauldrath merged commit b66346c into brandingbrand:develop Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cauldrath Cauldrath Cauldrath approved these changes

Assignees

@Cauldrath Cauldrath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willybeans @Cauldrath