Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fscomponents): FLAGSHIP-64 - Make Shelf a function component #990

Merged
merged 1 commit into from
Jan 22, 2020
Merged

fix(fscomponents): FLAGSHIP-64 - Make Shelf a function component #990

merged 1 commit into from
Jan 22, 2020

Conversation

hearsh
Copy link

@hearsh hearsh commented Jan 16, 2020

No description provided.

@hearsh
Copy link
Author

hearsh commented Jan 16, 2020

@bweissbart

@Cauldrath Cauldrath self-assigned this Jan 22, 2020
@Cauldrath
Copy link

Cauldrath commented Jan 22, 2020 •
edited
Loading

In the future, you should include testing instructions in your description and make your branch on your fork so you aren't creating a branch in the main repo.

Cauldrath
Cauldrath approved these changes Jan 22, 2020
View reviewed changes
Copy link

@Cauldrath Cauldrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@Cauldrath Cauldrath merged commit e50068d into develop Jan 22, 2020
@Cauldrath Cauldrath deleted the FLAGSHIP-64 branch January 22, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cauldrath Cauldrath Cauldrath approved these changes

Assignees

@Cauldrath Cauldrath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hearsh @Cauldrath