feat(fsnetwork): Add option for interceptor #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the option to specify interceptor functions, mostly for error logging: https://www.npmjs.com/package/axios#interceptors
bweissbart
approved these changes
Sep 23, 2019
bweissbart
added a commit
that referenced
this pull request
Oct 31, 2019
* chore(fscomponents): const name to clearicon from cancelicon * chore: refactor ccard validation to remove moment This refactors the validation in the CreditCardForm component to eliminate the need for the moment library. Because we were using moment to simply grab the month and date off a MM/YY formatted string it was easy to change. This helps us achieve our goal of removing dependencies to moment because it's a huge library. * fix(fscomponents): flatten validation for cc number to onblur * chore: tell greenkeeper to ignore react-native updates This updates the Greenkeeper configuration to always ignore react-native updates, as we should never be merging in react-native updates without developer oversight. Syntax per the Greenkeeper docs: https://greenkeeper.io/docs.html#monorepo * feat: android init config add various config based values that inject into Android template this allows for modifying the Android project during the init command * fix: update react-native-htmlview to version 0.14.0 * feat(fsweb): Enable Progressive Web App Activates features required to build as a progressive web app. Also switches to Workbox, addressing issue #620 * fix(flagship): Remove deprecated lifecycle functions Removing componentWillReceiveProps and componentWillMount. * fix(fsweb): Match routers path-to-regexp The react-router uses path-to-regexp@^1.7.0, which generates paths differently from 2.4.0, which fsweb was using without specifying the version. Without this change, the router wasn't working, so you couldn't visit any non-root pages. * fix(pirateship): Use componentDidUpdate in PSProductDetail getDerivedStateFromProps wasn't properly propogating the commerceData property, so visiting a PDP without refreshing the page caused it to stay in a loading state forever. Switching to componentDidUpdate resolves the issue. Resolves #637 * Update README.md * feat: Add create-fs-app functionality To test/run locally: 1. Navigate to `packages/create-fs-app` 2. Run `yarn link` 3. You should be able to run `create-fs-app` now in the directory of your choosing * fix: Remove launch screen base config option This cannot be set to a default unless the files actually exist * fix: Fix app name config key * fix: Remove template config when writing a new one * fix: Add more stubbed configs * fix: Fix types and name variable for package.json * fix: Add check that script is running on node 10 or above * chore(release): publish v6.1.0 * fix(fsweb): tag type of css bundle * fix(create-fs-app): fix run cmd for android with certain bundleIds * ci(create-fs-app): remove node version restriction from package.json the node version restriction is enforced at runtime. removing the package.json configuration allows older node version (like those used in CI) to still build the package * fix(fsweb): Lock webpack version to 4.39.3 Version 4.40.0 introduces a bug that prevents web from compiling: webpack/webpack#9693 * chore(release): publish v6.1.1 * chore(release): publish v6.1.2 * chore(release): publish v6.1.3 * fix(fsweb): Lock web dependency versions Added package-lock.json file to fsweb to avoid grabbing new versions automatically and locked some versions to the new values. Also set webpack to 4.40.2 because they fixed the issue in 4.40.0 and added a ship:init-web command for easier debugging. * fix: fix network security config for android emulators (#817) android blocks http requests by default. the network security config was set up to work with physical devices, but not emulators * chore(release): publish v6.1.4 * chore: add unit test for android exception domains This test ensures that localhost, 10.0.2.2 (the Android emulator internal localhost IP), and any configured exception domains are added to the network security file in the Android project. * feat(fsapp): Track whether the drawer is visible (#814) Reimplementation of #658 with additional safety checks "isOpen" only tracks whether the drawer is open or closed, regardless of the animation transition. This adds a "drawerVisible" property for the wrapped component, which will allow the component to know whether it is displaying or not. This allows the component to, for example, hide itself when it isn't visible, to avoid being tabbed to. * fix(fsweb): Fix slashes for running web on Windows * fix(pirateship): Fixes for blacklist and linking Windows slashes * fix: bump leanplum sdk version (#823) * chore(release): publish v6.2.0 * feat(fsnetwork): Add option for interceptor (#808) Adds the option to specify interceptor functions, mostly for error logging: https://www.npmjs.com/package/axios#interceptors * chore(release): publish v6.3.0 * fix(flagship): Make android namespace match package name The namespace for native android code was always set to com.brandingbrand.reactnative.and.{config.name}, rather than using the defined ID. This lead to some issues with starting activities and imports. BREAKING CHANGE: If anything hard codes the android native project path (ie. android/app/src/main/java/com/brandingbrand/reactnative/and/project-name), it will need to be updated to account for the dynamic package name. Flagship now exports its own modules, so `flagship.path.android.nativeProjectPath(config)` can be used to get the directory without hard coding a path. * Revert yarn.lock changes * feat: update bv components w/ syndicated indicator **Description** Some reviews are syndicated by the manufacturer. When this is the case, if the client wants to display the indicator, another row will appear on the bottom of the review indicating that it is syndicated. * chore(release): publish v7.0.0 * feat(flagship): support background modes * feat: update bv syndicated indicator style **Description** There were some bugs with the syndication badges on smaller devices. Fixed them with flex-wrap. Also updated copy. * chore(release): publish v7.1.0 * feat: add position property for half modal component * chore: add state typing for component CMSBanner * fix: excessive calls of handleContainerSizeChange in MultiCarousel * fix: Gridlines are misaligned between products in Product Index #143 * fix: Add 'Marquis' feature to Button with title dynamically reflecting CTA state * fix(fscomponents): add arg to bv syndication badge render prop **Description** I needed to include the syndicationSource details in the renderSyndicatedIndicator prop * chore(release): publish v7.1.1 * fix(flagship): ios background modes returning undefine * refactor: Change login for Dimensions * fix: Development version number should be fixed to the bottom of viewport for web * fix: fix infinite re-render bug when using renderSyndicatedIndicator prop * feat(fsengagement): expose new inbox route that sets attributes * fix: create SyndicationIndicator component, simplify conditional * fix: remove unused function * chore(release): publish v7.2.0 * feat: add appcenter support to fastlane scripts This adds :appcenter lanes to the fastfile scripts for ios and android. When paired with the correct configuration, it will compile the app and then upload the build to App Center's distribution section. * refactor: pass property height from parent for component HalfModalScreen * feat(fsengagement): remove moment library * chore(fscomponents): add missing typedef to modalhalfscreen component (#862) * chore(release): publish v7.3.0 * fix(flagship): update string replace to work in new fastfile (#864) * fix(flagship): update string replace to work in new fastfile * chore(release): publish v7.4.0 * fix(flagship): add support for new pods * chore(release): publish v7.4.1 * fix: get default env from initial script * build: upgrade deprecated webpack dev server * chore: tell greenkeeper to ignore more dependencies react, metro-react-babel-preset, and babel should only be updated as part of coordinated React Native upgrades. * fix: Add itemCount to cart interface in fscommerce (#877) * fix: Modify the podspec version to ve 2.6.2 (#878) * build: upgrade deprecated webpack dev server * fix: remove unnecessary checks * fix(pirateship): Remove duplicate "name" in config (#867) * chore: Update react-native-masked-text * fix: exclude kotlin intermediate build files 3rd party libraries begin using Kotlin and intermediate`*.kotlin_module` files are causing build errors. Added this rule to exclude those files * chore: update react-dom library * chore: Update react-native-touch-id dependency * fix(flagship): Fix renaming edge case for android (#898) The only file/directory with "flagship" in the name was the package directory, which is already being renamed when fixing the package directory structure. Resolves #895 * fix(fsweb): Use yarn.lock for fsweb (#906) Allows us to lock versions of subdependencies when running fsweb. * chore(release): publish v7.4.2 * fix(fsweb): Lock babel runtime in package.json (#905) package-lock.json doesn't get published by npm, so this removes it and locks the version in package.json. This still leaves us open to other package updates breaking web, so I will be following up to see if yarn.lock doesn't have this issue. * chore(release): publish v7.4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to specify interceptor functions, mostly for error logging:
https://www.npmjs.com/package/axios#interceptors