feat(fsbazaarvoice): Expand review data source #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the test for FSNetwork is failing and it doesn't seem related to anything I touched. |
Cauldrath
reviewed
Feb 11, 2020
| Include: 'Products', | ||
| Stats: 'Reviews', | ||
| Limit: query.limit || 10 | ||
| Limit: query.limit || 10, | ||
| ...(query.sort ? {Sort: query.sort} : {}) |
There was a problem hiding this comment.
Why not just make it Sort: query.sort? Is it shoving in "Sort=undefined" that way?
There was a problem hiding this comment.
I didn't think to check to see if qs omits undefined parameters.
I just checked and qs indeed omits them, so I can change this.
Cauldrath
added a commit
to Cauldrath/flagship
that referenced
this pull request
Mar 26, 2020
fsbazaarvoice was upgraded in brandingbrand#1061 This makes the other packages use the same version.
crherman7
pushed a commit
to crherman7/flagship
that referenced
this pull request
Nov 14, 2022
fsbazaarvoice was upgraded in brandingbrand#1061 This makes the other packages use the same version. brandingbrand-source-id: b3111a290fe6c0b0c9b880cf4e66501dadde65d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new optional params to the bazaarvoice review data source while leaving existing functionality in place.
Filter allows for multiple values following the "Filter=first&Filter=second&Filter=third" format.
Found no existing framework to create a test case in flagship. In the interest of time, I tested it directly within the CVS app.