Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fscomponents): FLAGSHIP-87 update with translations #1031

Merged
merged 1 commit into from
Jan 29, 2020
Merged

refactor(fscomponents): FLAGSHIP-87 update with translations #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/fscomponents/src/components/Selector/Selector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export class Selector extends PureComponent<
<View style={styles.modalContent}>
<View style={[styles.modalHeader, this.props.modalHeaderStyle]}>
<Text style={[styles.title, this.props.modalHeaderTextStyle]}>
{this.props.title || 'Select'}
{this.props.title || FSI18n.string(componentTranslationKeys.select)}
</Text>
{this.renderCloseButton()}
</View>
Expand Down
3 changes: 2 additions & 1 deletion packages/fsi18n/src/translations/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,8 @@ export const keys: FSTranslationKeys = {
}
},
selector: {
close: 'Close'
close: 'Close',
select: 'Select'
},
multiCarousel: {
prevBtn: 'Show previous',
Expand Down
1 change: 1 addition & 0 deletions packages/fsi18n/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ export interface StepTranslations<KeyType> {

export interface SelectorTranslations<KeyType> {
close: KeyType;
select: KeyType;
}

export interface MultiCarouselTranslations<KeyType> {
Expand Down