Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Consume rewrite parameters, except told otherwise #346

Closed

Conversation

ibihim
Copy link
Collaborator

@ibihim ibihim commented Dec 13, 2024

What

If header or query params are consumed by kube-rbac-proxy, they will be cleaned up, except that the authz config states:

"insecurePassthrough": "true

Why

If a proxy and upstream interpret parameter from the request, the probability is high that they do it differently, which invites CVEs.
In Prometheus use-cases, we want that behavior, such that if someone wants to access namespace default, a particular authorization config can created the expected SubjectAccessRequest to the apiserver.

@stlaz
Copy link
Collaborator

stlaz commented Dec 16, 2024

Per our offline discussion, we should get rid of the query rewrites and stick with the header handling.

I'd suggest the switch for the handling logic to operate like a mode switch rather than the bool. We would have two modes:

  1. TerminatingEvaluation
  2. PassthroughEvaluation
    or whatever names seem fitting, and document them properly, including the dangers of passthrough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants