Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitespace #340

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

ShazaAldawamneh
Copy link

this ticket to resolve issue: (26) Add whitespace link

@stlaz
Copy link
Collaborator

stlaz commented Dec 3, 2024

The commit says "Add whitespace link". What does the 'link' part mean?

@stlaz stlaz added the sig-auth-acceptance issues created during review for sig-auth-acceptance label Dec 3, 2024
@stlaz
Copy link
Collaborator

stlaz commented Dec 3, 2024

Please sign your commits.

@ibihim
Copy link
Collaborator

ibihim commented Dec 3, 2024

The link was a link to Mo's comment. The initial issue was wrongly created and it stayed as is.

@stlaz
Copy link
Collaborator

stlaz commented Dec 3, 2024

Right, but why is that in the commit message?

@ShazaAldawamneh ShazaAldawamneh changed the title Add whitespace link fix issue 26 Add whitespace fix issue 26 Dec 3, 2024
@ShazaAldawamneh
Copy link
Author

it's my bad I know what Krzys meant because he explained the ticket when we have a meeting, and I forgot to ask him about the link word, will amend that and recommit with my signature @stlaz

@stlaz stlaz changed the title Add whitespace fix issue 26 Add whitespace Dec 5, 2024
@ibihim ibihim merged commit ad71c2c into brancz:sig-auth-acceptance Dec 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig-auth-acceptance issues created during review for sig-auth-acceptance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants