Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse JSON in JSONDiff #99

Merged
merged 2 commits into from
Nov 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions js/json.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import { JSONDiff, ValidJSON } from "./json";
import { NumericDiff } from "./number";
import { ExactMatch } from "./value";

test("JSON String Test", async () => {
const cases = [
Expand Down Expand Up @@ -105,3 +107,56 @@ test("Valid JSON Test", async () => {
expect(score).toEqual(expected);
}
});

test("Semantic JSON Test", async () => {
const cases = [
{ a: '{"x": 1, "y": 2}', b: '{"y": 2, "x": 1}', expected: 1 },
{
a: '{"zs": ["a", "b"], "x": 1, "y": 2}',
b: '{"y": 2, "zs": ["a", "b"], "x": 1}',
expected: 1,
},
{
a: '{"o1": {"x": 1, "y": 2}}',
b: '{"o1": {"y": 2, "x": 1}}',
expected: 1,
},
{
a: '{"xs": [{"o1": {"x": 1, "y": [2]}}]}',
b: '{"xs": [{"o1": {"y": [2], "x": 1}}]}',
expected: 1,
},
{
a: '{"o1": {"x": 2, "y": 2}}',
b: '{"o1": {"y": 2, "x": 1}}',
expected: 0.83333,
},
{
a: { o1: { x: 2, y: 2 } },
b: '{"o1": {"y": 2, "x": 1}}',
expected: 0.83333,
},
{ a: '{"x": 1, "y": 2}', b: '{"x": 1, "z": 2}', expected: 0.3333 },
{ a: "[1, 2]", b: "[1, 2]", expected: 1 },
{ a: "[1, 2]", b: "[2, 1]", expected: 0.66667 },
];

for (const { a, b, expected } of cases) {
for (const exactNumber of [true, false]) {
const score = (
await JSONDiff({
output: a,
expected: b,
numberScorer: exactNumber ? ExactMatch : NumericDiff,
})
).score;
if (!exactNumber) {
expect(score).toBeCloseTo(expected);
} else {
expect(Math.round((score ?? 0) * 100)).toBeLessThanOrEqual(
Math.round(expected * 100),
);
}
}
}
});
43 changes: 36 additions & 7 deletions js/json.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,28 @@ import { makePartial, ScorerWithPartial } from "./partial";
*/
export const JSONDiff: ScorerWithPartial<
any,
{ stringScorer?: Scorer<string, {}>; numberScorer?: Scorer<number, {}> }
{
stringScorer?: Scorer<string, object>;
numberScorer?: Scorer<number, object>;
preserveStrings?: boolean;
}
> = makePartial(
async ({
output,
expected,
stringScorer = LevenshteinScorer,
numberScorer = NumericDiff,
preserveStrings = false,
}) => {
return {
name: "JSONDiff",
score: await jsonDiff(output, expected, stringScorer, numberScorer),
score: await jsonDiff(
output,
expected,
stringScorer,
numberScorer,
preserveStrings,
),
};
},
"JSONDiff",
Expand All @@ -42,9 +53,19 @@ export const ValidJSON: ScorerWithPartial<string, { schema?: any }> =
async function jsonDiff(
o1: any,
o2: any,
stringScorer: Scorer<string, {}>,
numberScorer: Scorer<number, {}>,
stringScorer: Scorer<string, object>,
numberScorer: Scorer<number, object>,
preserveStrings: boolean,
): Promise<number | null> {
if (!preserveStrings) {
if (typeof o1 === "string" && validJSON(o1) === 1) {
o1 = JSON.parse(o1);
}
if (typeof o2 === "string" && validJSON(o2) === 1) {
o2 = JSON.parse(o2);
}
}

if (isObject(o1) && isObject(o2)) {
if (Object.keys(o1).length == 0 && Object.keys(o2).length == 0) {
return 1;
Expand All @@ -58,9 +79,12 @@ async function jsonDiff(
),
);

// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
const baseScores = (
await Promise.all(
allKeys.map((k) => jsonDiff(o1[k], o2[k], stringScorer, numberScorer)),
allKeys.map((k) =>
jsonDiff(o1[k], o2[k], stringScorer, numberScorer, preserveStrings),
),
)
).filter((s) => s !== null) as number[];
return baseScores.reduce((acc, s) => acc + s, 0) / baseScores.length;
Expand All @@ -69,11 +93,14 @@ async function jsonDiff(
return 1;
}

// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
const baseScores = (
await Promise.all(
Array.from({
length: Math.min(o1.length, o2.length),
}).map((_, i) => jsonDiff(o1[i], o2[i], stringScorer, numberScorer)),
}).map((_, i) =>
jsonDiff(o1[i], o2[i], stringScorer, numberScorer, preserveStrings),
),
)
).filter((s) => s !== null) as number[];
return (
Expand Down Expand Up @@ -134,7 +161,9 @@ function validJSON<T>(output: string, schema?: Schema | JSONSchemaType<T>) {
if (isObject(parsed) || isArray(parsed)) {
return 1;
}
} catch (err) {}
} catch {
// Ignore errors
}

return 0;
}
Expand Down
10 changes: 9 additions & 1 deletion py/autoevals/json.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,22 @@ class JSONDiff(ScorerWithPartial):
(defaults to Levenshtein) and numbers (defaults to NumericDiff).
"""

def __init__(self, string_scorer: Scorer = None, number_scorer: Scorer = None):
def __init__(self, string_scorer: Scorer = None, number_scorer: Scorer = None, preserve_strings: bool = False):
self.string_scorer = string_scorer or Levenshtein()
self.number_scorer = number_scorer or NumericDiff()
self.preserve_strings = preserve_strings
self._valid_json = ValidJSON()

def _run_eval_sync(self, output, expected=None, **kwargs):
return Score(name=self._name(), score=self.json_diff(output, expected))

def json_diff(self, o1, o2):
if not self.preserve_strings:
if isinstance(o1, str) and self._valid_json.valid_json(o1) == 1:
o1 = json.loads(o1)
if isinstance(o2, str) and self._valid_json.valid_json(o2) == 1:
o2 = json.loads(o2)

if isinstance(o1, dict) and isinstance(o2, dict):
if len(o1) == 0 and len(o2) == 0:
return 1
Expand Down
45 changes: 45 additions & 0 deletions py/autoevals/test_json.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
from pytest import approx

from autoevals.json import JSONDiff, ValidJSON
from autoevals.number import NumericDiff
from autoevals.value import ExactMatch


def test_string_as_json():
Expand Down Expand Up @@ -98,3 +100,46 @@ def test_valid_json():
for output, expected, schema in cases:
print(f"[{output}]", expected)
assert evaluator(output, schema).score == expected


def test_semantic_json():
cases = [
('{"x": 1, "y": 2}', '{"y": 2, "x": 1}', 1),
(
'{"zs": ["a", "b"], "x": 1, "y": 2}',
'{"y": 2, "zs": ["a", "b"], "x": 1}',
1,
),
(
'{"o1": {"x": 1, "y": 2}}',
'{"o1": {"y": 2, "x": 1}}',
1,
),
(
'{"xs": [{"o1": {"x": 1, "y": [2]}}]}',
'{"xs": [{"o1": {"y": [2], "x": 1}}]}',
1,
),
(
'{"o1": {"x": 2, "y": 2}}',
'{"o1": {"y": 2, "x": 1}}',
0.83333,
),
(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case is identical to the one above it.

{"o1": {"x": 2, "y": 2}},
'{"o1": {"y": 2, "x": 1}}',
0.83333,
),
('{"x": 1, "y": 2}', '{"x": 1, "z": 2}', 0.3333),
("[1, 2]", "[1, 2]", 1),
("[1, 2]", "[2, 1]", 0.66667),
]

evaluator = JSONDiff()
for a, b, expected in cases:
for exact_number in [True, False]:
score = evaluator(a, b, number_scorer=ExactMatch() if exact_number else NumericDiff()).score
if not exact_number:
assert abs(score - expected) < 0.0001
else:
assert round(score * 100) <= round(expected * 100)
Loading