Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

Open API Specification v3 #6

Closed

Conversation

adambutler
Copy link

@adambutler adambutler commented Aug 2, 2017

Changes library to support for Open API Specification v3.0.0

Fixes #5

@drewolson
Copy link
Contributor

@adambutler Thanks! We'll take a look at this soon.

@adambutler
Copy link
Author

👋 Just pinging a reminder on this PR.

I just wanted to mention I've been using this for https://github.com/Nexmo/nexmo-developer without any issues so far.

You can see an example where this is used here

@drewolson
Copy link
Contributor

I apologize for not getting around to this yet. Unfortunately, our internal usage of OpenAPI is not yet on v3, so this may be challenging to merge at this time. I'll have more time to look in-depth at this in the next few weeks.

@drewolson
Copy link
Contributor

For the time being, I think we're going to have to avoid merging this. We rely on v2 of the specification internally and this would break our usage. I'll come back to this PR if / when we upgrade.

Sorry for the delay in the response!

@drewolson drewolson closed this Nov 2, 2017
@adambutler
Copy link
Author

Hey @drewolson thanks for following up on this but I'd like to make a case for you reconsidering if possible.

I appreciate that you using v2 of the spec but I think when you take the namespace of something encompassing like open_api_parser on Rubygems.org then I think it is reasonable that open source component shouldn't be constrained by the founding author.

We rely on v2 of the specification internally and this would break our usage.

I've changed the version of this following Semver to 2.0.0 can you not just specify the version in your Gemfile:

gem 'open_api_parser', '~> 1.2.1'

Alternatively I'd like to ask if you would be willing to do any of the following:

  1. Work with me to make adding OAS3 support a non-breaking change.

  2. Release the namespace to me on RubyGems. Changing this to something like open_api_v2_parser.

If none of these are options for you I'll likely fork the project into a seperate Gem and would welcome contirbutions if / when you've migrated to OAS3.

@why-el
Copy link

why-el commented Jun 1, 2018

@adambutler perhaps you can release a V3 yourself by forking this project?

@adambutler
Copy link
Author

@why-el I ended up building this project: https://github.com/nexmo/oas_parser

@why-el
Copy link

why-el commented Jun 1, 2018

Oh yeah, I was actually looking at that right now. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants