Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to disable PayPal using DropInRequest #27

Closed
mrsasha opened this issue Mar 23, 2017 · 2 comments
Closed

No way to disable PayPal using DropInRequest #27

mrsasha opened this issue Mar 23, 2017 · 2 comments

Comments

@mrsasha
Copy link

mrsasha commented Mar 23, 2017

General information

  • SDK/Library version: 3.0.6
  • Environment: all
  • Android Version and Device: doesn't matter

Issue description

Hi, I've tried using the DropInRequest.disablePaypal() method but it does nothing, and looking through the code of the SupportedPaymentMethodsAdapter, it's just checking the Configuration to see if Paypal is enabled, but the explicit flag passed in DropInRequest is not used.
@lkorth
Copy link
Member

lkorth commented Mar 23, 2017

Thanks for the report @mrsasha. It is indeed being ignored, as is the option to disable Venmo. We'll fix it and release it shortly.

lkorth added a commit that referenced this issue Mar 24, 2017
@lkorth
Respect DropInRequest payment method overrides
ed61e88 
Fixes #27
@lkorth lkorth mentioned this issue Mar 24, 2017
Merged
lkorth added a commit that referenced this issue Mar 24, 2017
@lkorth
Respect DropInRequest payment method overrides
ba5adc0 
Fixes #27
@lkorth
Copy link
Member

lkorth commented Mar 25, 2017

The fix for this was released in 3.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lkorth @mrsasha