Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[delay] rewrite previous delay APIs so that they are compatible with new brainpy version #522

Merged
merged 14 commits into from
Oct 24, 2023

Conversation

chaoming0625
Copy link
Collaborator

Description

How Has This Been Tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which updates documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe here):

Checklist

  • Code follows the code style of this project.
  • Changes follow the CONTRIBUTING guidelines.
  • Update necessary documentation accordingly.
  • Lint and tests pass locally with the changes.
  • Check issues and pull requests first. You don't want to duplicate effort.

Other information

1. ``__load_state`` and ``__save_state__`` receive ``**kwargs`` inputs, meaning that each node can process information by using item in **kwargs

2. remove ``load_states`` and ``save_states``, and the associated io functionalities
1. all local state reset happens in `reset_state()` function

2. all states reset under this node occurs in `reset()` function
1. in the brainpy 2.4.x version, the delay is registered with ``return_info()`` function. From now on, the delay can be registered as ``.register_local_delay('spike', 'pre', 1.)``.

2. this generalizes  the delay registration APIs so it can be used to register of any variables
@chaoming0625 chaoming0625 merged commit e849a9a into brainpy:master Oct 24, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant