Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating English Glossary with Missing Terms #121

Closed
7 tasks done
licataae opened this issue Dec 3, 2022 · 5 comments · Fixed by #126
Closed
7 tasks done

Updating English Glossary with Missing Terms #121

licataae opened this issue Dec 3, 2022 · 5 comments · Fixed by #126

Comments

@licataae
Copy link
Contributor

licataae commented Dec 3, 2022 •
edited
Loading

Updating the Brainhack Book Glossary (English) by adding in all missing terms & ordering alphabetically. The updated glossary is here: https://docs.google.com/document/d/1K_8P_u2th7JGtxpHli33VBqUgeTFBRtAEI3mGOZhRJ0/edit

  • I read and understood the project description.
  • I read and understood the workflow & contribution guidelines
  • Missing terms have been added
  • Missing terms have been proofread
  • Reviews from (at least) two native speakers have been requested (link reviewer names/profiles): Lucy Mohrhauer, Patrick Callahan
  • Reviews from two native speakers have been incorporated into the glossary
  • Completed, proofread and reviewed glossary has been merged to the main branch via PR
@Remi-Gau
Copy link
Member

Remi-Gau commented Dec 4, 2022

Wow. This is awesome!

Do you want to open a pull request to update this file with the new content: https://github.com/brainhackorg/brainhack_jupyter_book/blob/main/brainhack_book/glossary_en.md ?

@licataae
Copy link
Contributor Author

licataae commented Dec 5, 2022

Sure thing ! Just opened a PR.

@Remi-Gau Remi-Gau mentioned this issue Dec 5, 2022
Merged
Remi-Gau pushed a commit that referenced this issue Dec 7, 2022
@licataae @pre-commit-ci
Added missing terms to English glossary #121 (#126)
925d81e 
* Added missing terms to English glossary

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@Remi-Gau Remi-Gau mentioned this issue Dec 7, 2022
Closed
@Remi-Gau
Copy link
Member

Remi-Gau commented Dec 7, 2022

@licataae

do Lucy Mohrhauer and Patrick Callahan have github account?

why: trying to keep track of contributors ?

@licataae
Copy link
Contributor Author

licataae commented Dec 7, 2022

Patrick does (@NeuroShepherd) but Lucy does not, unfortunately...

@Remi-Gau
Copy link
Member

Remi-Gau commented Dec 7, 2022

ok thanks
either way I now know either where to find it if it exists or not to look for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added missing terms to English glossary #121 licataae/translate-bh-glossary
2 participants
@Remi-Gau @licataae