Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release nwbview 0.2.4 #35

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Release nwbview 0.2.4 #35

merged 3 commits into from
Mar 14, 2023

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Mar 14, 2023

The release solves #33.

I was wrong about the include directive of cargo.toml. It is not needed when I compile it on the project directory but the cargo publish command compiles it in a different directory and the static/icon.png needs to be copied there to be present at compile time.

@@ -14,7 +14,8 @@ include = [
  "Cargo.lock",
  "Cargo.toml",
  "LICENSE",
  "src/**/*"
  "src/**/*",
  "static/icon.png",
]

@anilbey anilbey requested a review from adrien-berchet March 14, 2023 16:32
@adrien-berchet
Copy link
Contributor

Ah 😅

@adrien-berchet
Copy link
Contributor

And did you see #34 (comment) ?

@anilbey anilbey changed the title Release nwbview 2.4.0 Release nwbview 0.2.4 Mar 14, 2023
@anilbey
Copy link
Contributor Author

anilbey commented Mar 14, 2023

Oh, I didn't. :) Now I see. Reading...

@anilbey
Copy link
Contributor Author

anilbey commented Mar 14, 2023

Thanks it is simpler now :)

@adrien-berchet
Copy link
Contributor

You're welcome :)
Now it looks good to me!

@anilbey anilbey merged commit 224ff13 into master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants