Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor plot.rs #23

Merged
merged 7 commits into from
Jan 17, 2023
Merged

refactor plot.rs #23

merged 7 commits into from
Jan 17, 2023

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Jan 16, 2023

Changes

  • extracts compute_step_size as a function
  • renames plot struct/trait/methods, their previous names were taken from an EGUI example

adrien-berchet
adrien-berchet approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@adrien-berchet adrien-berchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anilbey anilbey merged commit 967aaad into master Jan 17, 2023
@adrien-berchet adrien-berchet deleted the plot branch February 2, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-berchet adrien-berchet adrien-berchet approved these changes

@crisely09 crisely09 Awaiting requested review from crisely09

@JCGoran JCGoran Awaiting requested review from JCGoran

@rai-pranav rai-pranav Awaiting requested review from rai-pranav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anilbey @adrien-berchet