Refactor #17
Merged
Refactor #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I let a few useless stuff that I will have to clean later. |
anilbey
reviewed
Dec 6, 2022
src/gui.rs
Outdated
| match file.path { | ||
| None => println!("Could not load the file!"), | ||
| Some(x) => (self.loaded_files) | ||
| .push(hdf::read_nwb_file(&x.display().to_string()).unwrap()), |
There was a problem hiding this comment.
Here there's a small inconsistency between the drag&drop and file picker.
When we select a non-nwb file using the file picker, it says:
Could not load /home/anil/work/Text File.txt
When we drag and drop the same file however it panics.
`thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/gui.rs:144:76
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace`
Maybe drag & drop can also say "could not load the file" instead of panicking.
There was a problem hiding this comment.
Ah yes yes, I forgot a match here. I will fix that.
There was a problem hiding this comment.
Should be good now.
adrien-berchet
force-pushed
the
refactor
branch
from
6c010b8 to
85c845a
Compare
anilbey
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a first version of the refactoring I mentioned to be able to store several files and fetch their dataset hierarchies.
It's currently not working, I have an issue with borrowing mutable and immutable reference but I will see that later (or @anilbey you know how to fix it? 😇 ).
Does this refactoring makes sense to you?