Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Officially support Rails 5.2 #51

Merged
merged 1 commit into from
Sep 15, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ gemfile:
- gemfiles/Gemfile.rails-4-2
- gemfiles/Gemfile.rails-5-0
- gemfiles/Gemfile.rails-5-1
- gemfiles/Gemfile.rails-5-2

install:
- bundle install
Expand Down
7 changes: 4 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
## x.y.z (unreleased)

### Added
- Officially support Rails 5.2
([#51](https://github.com/braingourmets/currency_select/pull/51))
- Add Ruby 2.5.1 to the Travis build matrix
([#49](https://github.com/braingourmets/currency_select/pull/49))

Expand Down Expand Up @@ -38,8 +40,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
### Deprecated
- Support for Rails < 5.0.0 will be removed in version 2.0.0.
- Support for Rails < 4.2.0 will be removed in version 1.0.0.
- Support for Ruby < 2.2.2 will be removed in version 2.0.0.
- Support for Ruby < 2.0.0 will be removed in version 1.0.0.
- Support for Ruby < 2.3.0 will be removed in version 1.0.0.

### Removed
- Remove pre-Rails-4.0-specific code
Expand All @@ -54,7 +55,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
([#27](https://github.com/braingourmets/currency_select/pull/27))
- Use ISO codes as select values, not the IDs
([#24](https://github.com/braingourmets/currency_select/pull/24))
- Fix the the Gemfile
- Fix the Gemfile
([#19](https://github.com/braingourmets/currency_select/pull/19))
- Fix the order of name attribute and ID in the specs
([#18](https://github.com/braingourmets/currency_select/pull/18))
3 changes: 2 additions & 1 deletion currency_select.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ Gem::Specification.new do |s|
s.files = %w(lib/currency_select.rb rails/init.rb CHANGELOG.md CODE_OF_CONDUCT.md currency_select.gemspec Gemfile LICENSE Rakefile README.md VERSION)
s.extra_rdoc_files = %w(CHANGELOG.md LICENSE README.rdoc)

s.add_runtime_dependency 'actionview'
s.add_runtime_dependency 'actionview', '>= 4.2.0', '< 6.0'
s.add_runtime_dependency 'money'

s.add_development_dependency 'rspec-rails'
end
7 changes: 7 additions & 0 deletions gemfiles/Gemfile.rails-5-2
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# frozen_string_literal: true

source 'http://rubygems.org'

gem 'rails', '~> 5.2.0'

gemspec path: '../'