Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multiple screenshot file formats #341

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

IgorTatarnikov
Copy link
Member

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Currently we only support saving screenshots as .png. vedo seems to support .pdf, .eps, .jpg, and .svg. I don't see why we couldn't as well!

What does this PR do?
Adds a check to make sure the suffix of the file name is supported before passing it back to vedo. If there's no suffix, or it's not supported it just saves it as a .png.

References

Closes #340

How has this PR been tested?

Tested locally

Is this a breaking change?

No

Does this PR require an update to the documentation?

Yes, need to document the supported file formats. There are seems to be some weird behaviour when saving as .eps or .svg where they're written as .eps.gz or .svg.gz and have to be uncompressed first.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.47%. Comparing base (f3103ba) to head (0fdfcce).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   86.47%   86.47%           
=======================================
  Files          27       27           
  Lines        1220     1220           
=======================================
  Hits         1055     1055           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IgorTatarnikov IgorTatarnikov marked this pull request as ready for review April 24, 2024 17:50
@IgorTatarnikov IgorTatarnikov requested a review from a team April 24, 2024 17:50
@alessandrofelder alessandrofelder merged commit 60635e2 into main Apr 25, 2024
12 checks passed
@alessandrofelder alessandrofelder deleted the screenshot-types branch April 25, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support multiple file types for screenshots
2 participants