Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to 3.10-3.12 support #147

Merged
merged 3 commits into from
Jun 13, 2024
Merged

move to 3.10-3.12 support #147

merged 3 commits into from
Jun 13, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Jun 10, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

Current NEP 24 dictates we should support Python versions 3.10-3.12

What does this PR do?

  • Moves pyproject.toml and CI to Python 3.10 - 3.12
  • removes tox.ini (all handled inside pyproject.toml now)
  • moves check-manifest setup from pyproject.toml to pre-commit configuration

References

\

How has this PR been tested?

Running tox locally on 3.12 and running CI checks, with changed versions of the code.

Is this a breaking change?

No (apart from removing Python 3.9 support)

Does this PR require an update to the documentation?

I don't think so

Checklist:

  • The code has been tested locally
  • [ \ ] Tests have been added to cover all new functionality (unit & integration)
  • [ \ ] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder self-assigned this Jun 10, 2024
@alessandrofelder alessandrofelder marked this pull request as ready for review June 10, 2024 16:17
@alessandrofelder alessandrofelder requested a review from a team June 10, 2024 16:17
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.99%. Comparing base (67d391c) to head (56f4bd1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files          10       10           
  Lines         448      448           
=======================================
  Hits          439      439           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

while we're updating the package infrastructure
@alessandrofelder alessandrofelder removed the request for review from a team June 10, 2024 17:05
Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alessandrofelder you didn't request my review, but you can have it anyway :)

@alessandrofelder alessandrofelder merged commit 729fa20 into main Jun 13, 2024
13 checks passed
@alessandrofelder alessandrofelder deleted the python-312 branch June 13, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants