Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update regression test data #230

Merged
merged 9 commits into from
Feb 5, 2025
Merged

update regression test data #230

merged 9 commits into from
Feb 5, 2025

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Feb 4, 2025

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

Due to a recent bugfix to the atlas API hemisphere calculation, the regression data for brainreg is out of date.

What does this PR do?
Updates regression data for all OS.
Note that regression data is different per OS (thanks to @JoeZiminski for regenerating on Windows 🙏 😇 ) - here is a CI run comparing up-to-date Linux data on other OSs.

How has this PR been tested?

Tests pass locally for their OS, and didn't before.

@alessandrofelder alessandrofelder changed the title update Linux test data update regression test data Feb 4, 2025
@alessandrofelder alessandrofelder marked this pull request as ready for review February 4, 2025 18:08
@alessandrofelder alessandrofelder requested a review from a team February 4, 2025 18:09
Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both!

@adamltyson adamltyson merged commit b4a6eb2 into main Feb 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants