brainglobe_space name change #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
👍
Though the segmentation fault is not a pleasant thing to see. Nor do I expect to see it since nothing is actually changing 🤔 Could be a pytest-related thing?
It's also remarkably similar to the seg-fault we found on python 3.10 over on the cellfinder repo itself too.
|
Presumably it is the same issue considering brainmapper uses cellfinder? |
We've since released a version of cellfinder that has that patch in it. But it seems that a re-run has fixed this problem? I'm very confused! |
|
yep I was concerned too (and mixed feelings about how re-running fixed it...) |
willGraham01
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update references to brainglobe_space in brainmapper after name change.