Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages that are shipped #37

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Update packages that are shipped #37

merged 3 commits into from
Jan 3, 2024

Conversation

willGraham01
Copy link
Collaborator

Closes #14 | Closes #30 | Closes #35

Changes to shipped packages

Changes to package internals

Since the (meta)-package and some of the underlying tools are not on conda-forge yet, this PR removes the functionality that was introduced to try and manage this.
We have since started the migration to BrainGlobe version 1, which is a natural point to then retry getting the meta-package and it's dependents onto conda-forge all at once.

This should also be part of the wider discussion in #5.
We've since moved some tools around and renamed others, so the previous exposure under the "old" names has been removed (users will just import brainreg for example after pip install brainglobe-meta), this can be added in again alongside BG-version 1 once the restructuring is complete.

@willGraham01 willGraham01 requested a review from a team January 3, 2024 09:47
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (337f118) 71.42% compared to head (7a21441) 60.00%.

Files Patch % Lines
brainglobe/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #37       +/-   ##
===========================================
- Coverage   71.42%   60.00%   -11.43%     
===========================================
  Files           2        1        -1     
  Lines          28        5       -23     
===========================================
- Hits           20        3       -17     
+ Misses          8        2        -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willGraham01 willGraham01 merged commit 8b5112a into main Jan 3, 2024
9 of 11 checks passed
@willGraham01 willGraham01 deleted the ship-brainrender branch January 3, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants