-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update amplifier.h #712
Merged
Merged
Update amplifier.h #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added #include <cstdint> in line 56
I dont understand why this header is needed here, I dont see any non default int like types in it. Which error does it solve? And even if it should be a part of this header, I believe it should be added together with system includes a couple of lines above |
ah, ok there is uint64_t, is it the issue? If its the case lets just move this include up to system includes |
Hi,
The uname output:
(eeg2) ***@***.***:~/Projects/EEG2/brainflow/tools$ uname -a
Linux localhost.localdomain 6.6.0-1003-apple-arm #3-Ubuntu SMP
PREEMPT_DYNAMIC Wed Dec 27 01:40:02 UTC 2023 aarch64 aarch64 aarch64
GNU/Linux
I run ubuntu on a Mac Powerbook M1 and a Orange Pi 5 plus.
I downloaded brainflow again and ran with this output w/o the cstdint
statement:
/home/ubuntu/Projects/EEG2/brainflow/third_panrty/ant_neuro/eemagine/sdk/amplifier.h:94:46:
error: uint64_t was not declared in this scope
94 | if (ref_mask & ((uint64_t)1 <<
ref_counter))
| ^~~~~~~~
/home/ubuntu/Projects/EEG2/brainflow/third_party/ant_neuro/eemagine/sdk/amplifier.h:56:1:
note: uint64_t is defined in header <cstdint>; did you forget to #include
<cstdint>?
55 | #include <eemagine/sdk/stream.h>
+++ |+#include <cstdint>
56 |
/home/ubuntu/Projects/EEG2/brainflow/third_party/ant_neuro/eemagine/sdk/amplifier.h:94:55:
error: expected ) before numeric constant
94 | if (ref_mask & ((uint64_t)1 <<
ref_counter))
| ^
/home/ubuntu/Projects/EEG2/brainflow/third_party/ant_neuro/eemagine/sdk/amplifier.h:94:44:
note: to match this (
94 | if (ref_mask & ((uint64_t)1 <<
ref_counter))
| ^
/home/ubuntu/Projects/EEG2/brainflow/third_party/ant_neuro/eemagine/sdk/amplifier.h:98:31:
error: expected ) before ref_counter
98 | ++ref_counter;
| ^~~~~~~~~~~
/home/ubuntu/Projects/EEG2/brainflow/third_party/ant_neuro/eemagine/sdk/amplifier.h:94:32:
note: to match this (
94 | if (ref_mask & ((uint64_t)1 <<
ref_counter))
| ^
/home/ubuntu/Projects/EEG2/brainflow/third_party/ant_neuro/eemagine/sdk/amplifier.h:101:46:
error: uint64_t was not declared in this scope
101 | if (bip_mask & ((uint64_t)1 <<
bip_counter))
| ^~~~~~~~
/home/ubuntu/Projects/EEG2/brainflow/third_party/ant_neuro/eemagine/sdk/amplifier.h:101:46:
note: uint64_t is defined in header <cstdint>; did you forget to #include
<cstdint>?
/home/ubuntu/Projects/EEG2/brainflow/third_party/ant_neuro/eemagine/sdk/amplifier.h:101:55:
error: expected ) before numeric constant
101 | if (bip_mask & ((uint64_t)1 <<
bip_counter))
| ^
/home/ubuntu/Projects/EEG2/brainflow/third_party/ant_neuro/eemagine/sdk/amplifier.h:101:44:
note: to match this (
101 | if (bip_mask & ((uint64_t)1 <<
bip_counter))
| ^
/home/ubuntu/Projects/EEG2/brainflow/third_party/ant_neuro/eemagine/sdk/amplifier.h:105:31:
error: expected ) before bip_counter
105 | ++bip_counter;
| ^~~~~~~~~~~
/home/ubuntu/Projects/EEG2/brainflow/third_party/ant_neuro/eemagine/sdk/amplifier.h:101:32:
note: to match this (
101 | if (bip_mask & ((uint64_t)1 <<
bip_counter))
I reran once more with the #include <cstdint> statement in amplifier.h and
it worked. You know more about the architecture, so if the #include
<cstdint> should be moved higher up in the architecture, it would probably
work.
Warm regards/Med vennlig hilsen
Einar Jørgensen
Daglig Lederctsdint
Fullflyt AS
Mobil: +47 982 33 894 <982%2033%20894>
email: einar@ ***@***.***>fullflyt.no
tir. 2. apr. 2024 kl. 23:19 skrev Andrey Parfenov ***@***.***
…:
ah, ok there is uint64_t, is it the issue? If its the case lets just move
this include up to system includes
—
Reply to this email directly, view it on GitHub
<#712 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOTPXD6YQU4MAHFLHRFDBNTY3M4J7AVCNFSM6AAAAABFTAA7F2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZTGI3TAOBWGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
thanks |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added #include in line 56