Slightly modified definition of CliffordNumbers.signbit_of_square

brainandforce · Jun 4, 2024 · 500474a · 500474a
1 parent 348eb5e
commit 500474a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/bitindex.jl b/src/bitindex.jl
@@ -199,9 +199,11 @@ end
     CliffordNumbers.signbit_of_square(b::BitIndex) -> Bool
 
 Returns the signbit associated with squaring the basis blade indexed by `b`.
+
+For basis blades squaring to zero, the result is not meaningful.
 """
 function signbit_of_square(b::BitIndex{Q}) where Q
-    return xor(!iszero(grade(b) & 2), isodd(count_ones(UInt(b) & ~positive_square_bits(Q))))
+    return xor(!iszero(grade(b) & 2), isodd(count_ones(UInt(b) & negative_square_bits(Q))))
 end
 
 """