Fixed definitions of left and right complement

brainandforce · Jun 5, 2024 · 4079734 · 4079734
1 parent 13a29ad
commit 4079734
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/bitindex.jl b/src/bitindex.jl
@@ -300,6 +300,10 @@ end
 dual(b::BitIndex{Q}) where Q = b * BitIndex{Q}(false, typemax(UInt))
 undual(b::BitIndex{Q}) where Q = b * BitIndex{Q}(!iszero(dimension(Q) & 2), typemax(UInt))
 
+# This calculates the "inverse" of i
+# TODO: document this fully
+_inv(i::T) where T<:BitIndex = T(xor(signbit(i), signbit_of_square(i)), UInt(i))
+
 """
     left_complement(b::BitIndex{Q}) -> BitIndex{Q}
 
@@ -314,7 +318,7 @@ signature of `Q`, depending only on the dimension.
 
 Lengyel's convention for the left complement is an underbar.
 """
-left_complement(b::BitIndex{Q}) where Q = BitIndex{Q}(false, typemax(UInt)) * b'
+left_complement(b::BitIndex{Q}) where Q = BitIndex{Q}(false, typemax(UInt)) * _inv(b)
 
 """
     right_complement(b::BitIndex{Q}) -> BitIndex{Q}
@@ -330,4 +334,4 @@ of the signature of `Q`, depending only on the dimension.
 
 Lengyel's convention for the right complement is an overbar.
 """
-right_complement(b::BitIndex{Q}) where Q = b' * BitIndex{Q}(false, typemax(UInt))
+right_complement(b::BitIndex{Q}) where Q = _inv(b) * BitIndex{Q}(false, typemax(UInt))
diff --git a/src/multiply.jl b/src/multiply.jl
@@ -1,9 +1,5 @@
 #---Efficient multiplication kernels---------------------------------------------------------------#
 
-# This calculates the "inverse" of i
-# TODO: document this fully
-_inv(i::T) where T<:BitIndex = T(xor(signbit(i), signbit_of_square(i)), UInt(i))
-
 """
     CliffordNumbers.bitindex_shuffle(a::BitIndex{Q}, B::NTuple{L,BitIndex{Q}})
     CliffordNumbers.bitindex_shuffle(a::BitIndex{Q}, B::BitIndices{Q})