Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly wrong danish translation #327

Closed
Lars-Sommer opened this issue Nov 21, 2024 · 2 comments · Fixed by #328
Closed

Possibly wrong danish translation #327

Lars-Sommer opened this issue Nov 21, 2024 · 2 comments · Fixed by #328

Comments

@Lars-Sommer
Copy link

Cron Expression
0 3 * * 4

Expected Output
"Kl. 03:00 om torsdagen" or "Kl. 03:00 på torsdage"

Actual Output
"Kl 03:00, kun på torsdag"

I am wondering about this translation. In danish it says "Kl 03:00, kun på torsdag" which is a definite singular expression and means that the cron will only activate the following thursday, and not anymore. And this is of course wrong because the cron will actually activate every thursday.

I think this happens because it is directly translated from the english version "At 03:00 AM, only on Thursday". I am not an english expert, but I think the "only" ("kun" in danish) word in this english context does not exclude other thursdays as it does in danish. It roughly means that this will only happen on thursdays and not in any other weekdays.

Or am I missing something? :)

@rmja

@rmja
Copy link
Contributor

rmja commented Nov 21, 2024

Thanks! Yes, this is a bug. I have created a pr with a fix.

@Lars-Sommer
Copy link
Author

Awesome, tak 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants