Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithDialOptions option #71

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Add WithDialOptions option #71

merged 2 commits into from
Jan 14, 2020

Conversation

bradleyjkemp
Copy link
Owner

Fixes #69

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #71 into master will decrease coverage by 0.25%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   56.81%   56.55%   -0.26%     
==========================================
  Files          31       31              
  Lines        1167     1174       +7     
==========================================
+ Hits          663      664       +1     
- Misses        400      406       +6     
  Partials      104      104
Flag Coverage Δ
#integration 55.96% <25%> (-0.25%) ⬇️
#unit 18.84% <0%> (-0.4%) ⬇️
Impacted Files Coverage Δ
grpc-proxy/proxy.go 54.79% <ø> (ø) ⬆️
grpc-proxy/config.go 37.77% <0%> (-5.82%) ⬇️
grpc-proxy/grpc_handler.go 61.61% <100%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0f3370...e575949. Read the comment docs.

@bradleyjkemp bradleyjkemp merged commit 792de22 into master Jan 14, 2020
@bradleyjkemp bradleyjkemp deleted the withdialoptions branch January 14, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mTLS support and grpc-cache
1 participant