Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for marshalling from human-readable form #32

Merged
merged 5 commits into from
Jul 3, 2019

Conversation

bradleyjkemp
Copy link
Owner

This starts to address #10. I'd still like to be able to marshal from the unknown message format but this is a good first step of just supporting users who have the .proto definitions.

@bradleyjkemp bradleyjkemp added enhancement New feature or request grpc-replay labels Jul 2, 2019
@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   16.32%   16.32%           
=======================================
  Files           6        6           
  Lines         294      294           
=======================================
  Hits           48       48           
  Misses        240      240           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd0637...e7e723f. Read the comment docs.

Repository owner deleted a comment from codecov bot Jul 2, 2019
@bradleyjkemp bradleyjkemp merged commit 0c5b2ef into master Jul 3, 2019
@bradleyjkemp bradleyjkemp deleted the replay-human-readable branch July 3, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant