Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/jhump/protoreflect from 1.6.0 to 1.6.1 #100

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented May 12, 2020

Bumps github.com/jhump/protoreflect from 1.6.0 to 1.6.1.

Release notes

Sourced from github.com/jhump/protoreflect's releases.

v1.6.1

This release contains many bug fixes.

"github.com/jhump/protoreflect/desc"

Changes/fixes:

  • If a field descriptor is missing a json_name attribute, instead of using the proto field name, the library now falls back to computing a default JSON name in the same manner as protoc. This is necessary since descriptors that are generated into Java code by protoc, for example, do not have the attribute present unless the option was explicitly present in the source.

"github.com/jhump/protoreflect/desc/builder"

Changes/fixes:

  • Previously, messages with "message set wire encoding" were subject to the same tag limitations as other messages. However, message set wire encoding should be allowed to have a wider range of valid tags (all the way up to 2^31-2).

"github.com/jhump/protoreflect/desc/protoparse"

Changes/fixes:

  • This package now produces descriptors that are deterministic. Previously, custom options that were represented as unrecognized fields were serialized in non-deterministic order.
  • When using the new v1.4 protobuf runtime, descriptors produced by this package mistakenly omitted custom options. This is now corrected, and descriptors should now be complete when used with any protobuf runtime versions.
  • Previously, messages with "message set wire encoding" were subject to the same tag limitations as other messages. However, message set wire encoding should be allowed to have a wider range of valid tags (all the way up to 2^31-2).
  • Fixes numerous small issues in the parser, including some that caused its behavior to diverge from protoc.
    • Options should support extensions of custom option messages, using syntax like so:
      option (custom.option).(some.extension) = "foo";
      
      However, protoparse would fail with a syntax error upon seeing the second open parenthesis. This is now fixed.
    • Related to the "message set wire encoding" fix above, if a message with message set encoding had an extension range that referenced the keyword max, the actual end tag encoded in the descriptor was wrong and did not represent the full allowed range for message set encoding. This is now fixed.
    • Numeric literals that had no floating point were not allowed to exceed the range of an int64. However, it should be possible to use larger values when providing values for uint64, float, and double types. This is now fixed.
    • Groups can be used inside of a oneof (with syntax = "proto2"). And groups can have options. However protoparse rejected definitions of groups with options that were inside of a oneof. This is now fixed.
    • A oneof is valid if it has only groups (with syntax = "proto2"). However, protoparse mistakenly rejected oneofs, stating they had to have at least one field. This is now fixed.
    • Validating reserved statements in messages and enums failed to identify duplicate reserved names in some cases. This is now fixed.

"github.com/jhump/protoreflect/dynamic"

Changes/fixes:

  • When using the new v1.4 protobuf runtime, converting between generated and dynamic messages would mistakenly drop unrecognized fields and extensions. This is now corrected, and messages should preserve these fields when converting to and from dynamic messages to generated types.
Commits
  • e52bab9 work around the fact that v2 messages don't have an XXX_unrecognized field (#...
  • b6666e6 refactor protoparse, fixes multiple issues (#316)
  • b97137b fix broken tests due to recent protobuf deprecations (#310)
  • c1f7119 don't care about Go 1.9 and 1.10 anymore; add 1.13 and 1.14 to the list (#306)
  • 2f878b3 protoparse should produce deterministic results (#305)
  • e0a00a5 json name: refer to protoc impl in comments; more test cases (#298)
  • 259594d if no json_name attribute present; compute it the same way that protoc does (...
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label May 12, 2020
@dependabot-preview dependabot-preview bot requested a review from bradleyjkemp May 12, 2020 06:09
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   56.49%   56.49%           
=======================================
  Files          31       31           
  Lines        1177     1177           
=======================================
  Hits          665      665           
  Misses        408      408           
  Partials      104      104           
Flag Coverage Δ
#integration 55.90% <ø> (ø)
#unit 18.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac8f888...1b96a63. Read the comment docs.

Bumps [github.com/jhump/protoreflect](https://github.com/jhump/protoreflect) from 1.6.0 to 1.6.1.
- [Release notes](https://github.com/jhump/protoreflect/releases)
- [Commits](jhump/protoreflect@v1.6.0...v1.6.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/go_modules/github.com/jhump/protoreflect-1.6.1 branch from a0b20e0 to 1b96a63 Compare June 19, 2020 20:25
@bradleyjkemp bradleyjkemp merged commit 887a178 into master Jun 19, 2020
@bradleyjkemp bradleyjkemp deleted the dependabot/go_modules/github.com/jhump/protoreflect-1.6.1 branch June 19, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant