Fix/relative linking #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows definition to be optional. If no definition can be derived from the current context then relative links are not rendered since they will not render to the correct location. This will occur in some cases during completions since there is no way to figure out the definition of the completion data being returned when displaying that context via the
completionsEntryDetailsrequest.I would note that there are some cases that we can derive a context during a completion so when possible the links will be displayed.
It would probably be worth exploring
completionsEntryDetailsfrom at least returning enough information that can allow figuring out the definition that the completion data is coming from.