fix: large streaming uploads could fail with an invalid SHA-256 hash error #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6' header does not match what was computed." because a buffer was being re-used before it was fully finished being uploaded. The test didn't catch this because it had a sleep() and the data was too homogenous, so that buffer reuse didn't change the data.
This was referenced Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #12. It's similar to #14 but closer to the problem and includes a test.
Explanation of the bug: a buffer was being re-used before it was fully finished being uploaded. The "large upload" integration test didn't catch this because it had a sleep() and the data was too homogenous, so that buffer reuse didn't change the data.