Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Hitting Tab key when focus is on Next button in Find bar should not dismiss it. #4886

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by RaymondLim
Monday Sep 23, 2013 at 22:34 GMT
Originally opened as adobe/brackets#5309


  1. Open a page with some text that you can do Find Next or Find Prev.
  2. Hit Ctrl/Cmd+F to bring up the Find bar.
  3. Type some text that has multiple instances in the current document.
  4. Hit Tab keys three times.

Result: Find bar closes.
Expected: Tab key should cycle through all elements in the Find bar. That is, if the focus is on the last element, Tab should set focus to the first one. And if the focus is in the search field and Shift-Tab keys are pressed, then the focus should go to the last element in the Find bar.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Sep 30, 2013 at 18:12 GMT


Reviewed.@redmunds - please work with@rajeshsegu to see if he can help with this.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Tuesday Nov 05, 2013 at 01:25 GMT


Before the prev and next buttons were added, this was the behavior when hitting tab in Find text field. I assumed this was by design, so I just submitted pull request adobe/brackets#5848 for #5766 that restores this behavior to the text field.

Since the Find, Replace, and Find in Files dialogs will be totally rewritten soon, I don't think this is a Medium Priority, and I don't think we should spend time on this.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Tuesday Nov 05, 2013 at 22:31 GMT


This is also fixed (actually made obsolete) by pull request #5848.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Wednesday Nov 06, 2013 at 18:00 GMT


Closing since we no longer can tab to those buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant