Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Hitting Tab key when focus is on Next button in Find bar should not dismiss it. #5309

Closed
RaymondLim opened this issue Sep 23, 2013 · 4 comments
Assignees
Milestone

Comments

@RaymondLim
Copy link
Contributor

  1. Open a page with some text that you can do Find Next or Find Prev.
  2. Hit Ctrl/Cmd+F to bring up the Find bar.
  3. Type some text that has multiple instances in the current document.
  4. Hit Tab keys three times.

Result: Find bar closes.
Expected: Tab key should cycle through all elements in the Find bar. That is, if the focus is on the last element, Tab should set focus to the first one. And if the focus is in the search field and Shift-Tab keys are pressed, then the focus should go to the last element in the Find bar.

@ghost ghost assigned redmunds Sep 30, 2013
@njx
Copy link

njx commented Sep 30, 2013

Reviewed. @redmunds - please work with @rajeshsegu to see if he can help with this.

@redmunds
Copy link
Contributor

redmunds commented Nov 5, 2013

Before the prev and next buttons were added, this was the behavior when hitting tab in Find text field. I assumed this was by design, so I just submitted pull request #5848 for #5766 that restores this behavior to the text field.

Since the Find, Replace, and Find in Files dialogs will be totally rewritten soon, I don't think this is a Medium Priority, and I don't think we should spend time on this.

@redmunds
Copy link
Contributor

redmunds commented Nov 5, 2013

This is also fixed (actually made obsolete) by pull request #5848.

@RaymondLim
Copy link
Contributor Author

Closing since we no longer can tab to those buttons.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants