Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dropdown lists to use new DropdownEventHandler class #12413

Open
core-ai-bot opened this issue Aug 31, 2021 · 1 comment
Open

Cleanup dropdown lists to use new DropdownEventHandler class #12413

core-ai-bot opened this issue Aug 31, 2021 · 1 comment

Comments

@core-ai-bot
Copy link
Member

Issue by redmunds
Sunday Oct 27, 2013 at 17:38 GMT
Originally opened as adobe/brackets#5722


During development of CSS Quick Edit New Rule user story, I added a DropdownEventHandler class (utils/DropdownEventHandler) as a place to put common functionality for dropdown elements. But all of the other lists I looked at had just enough difference that it wasn’t easy to migrate:

  • Code Hints – Enter key handling when there’s “pending text”
  • Recent Projects – button to “remove from list”
  • Context Menus – currently have no keyboard support

So, we should take another look at consolidating some of this code.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Oct 28, 2013 at 18:38 GMT


Low priority code cleanup to@redmunds. Might also want to think about whether this is related to the general popup manager cleanup work in (#1381) (which was moved to backlog) or whether it's orthogonal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant