Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Cleanup dropdown lists to use new DropdownEventHandler class #5722

Open
redmunds opened this issue Oct 27, 2013 · 1 comment
Open

Cleanup dropdown lists to use new DropdownEventHandler class #5722

redmunds opened this issue Oct 27, 2013 · 1 comment

Comments

@redmunds
Copy link
Contributor

During development of CSS Quick Edit New Rule user story, I added a DropdownEventHandler class (utils/DropdownEventHandler) as a place to put common functionality for dropdown elements. But all of the other lists I looked at had just enough difference that it wasn’t easy to migrate:

  • Code Hints – Enter key handling when there’s “pending text”
  • Recent Projects – button to “remove from list”
  • Context Menus – currently have no keyboard support

So, we should take another look at consolidating some of this code.

@ghost ghost assigned redmunds Oct 28, 2013
@njx
Copy link

njx commented Oct 28, 2013

Low priority code cleanup to @redmunds. Might also want to think about whether this is related to the general popup manager cleanup work in (#1381) (which was moved to backlog) or whether it's orthogonal.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants