Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape entities in attributes #17

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

barmac
Copy link
Member

@barmac barmac commented Oct 1, 2024

Closes #16

Proposed Changes

This makes sure we handle properly SVGs like <g data-attr="&gt;" />.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

test/spec/innerSVG.js Outdated Show resolved Hide resolved
@nikku nikku merged commit 4cb2f5d into main Oct 1, 2024
4 checks passed
@nikku nikku deleted the 16-escape-special-characters-in-attributes branch October 1, 2024 13:20
@barmac
Copy link
Member Author

barmac commented Oct 1, 2024

I will backport this to v3.x since we have not adopted v4 yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

innerSVG does not escape < and > in attributes
2 participants